Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2858383002:
Move one test in an anonymous namespace. (Closed)
DescriptionMove one test in an anonymous namespace.
This avoids ODR violation on media::MockAudioManager.
BUG=709536
R=tommi@chromium.org,hans@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2858383002
Cr-Commit-Position: refs/heads/master@{#470708}
Committed: https://chromium.googlesource.com/chromium/src/+/97228865445e54c1dbdf9ea04f3ad4b900451af9
Patch Set 1 #
Total comments: 3
Patch Set 2 : . #Messages
Total messages: 20 (8 generated)
Description was changed from ========== Move one test in an anonymous namespace. This avoids ODR violation on media::MockAudioManager. BUG=709536 R=tommi@chromium.org,hans@chromium.org ========== to ========== Move one test in an anonymous namespace. This avoids ODR violation on media::MockAudioManager. BUG=709536 R=tommi@chromium.org,hans@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Thanks for getting to the bottom of this one! lgtm Tommi or someone familiat with media/ should probably comment as well.
On 2017/05/08 22:53:15, hans wrote: > Thanks for getting to the bottom of this one! lgtm > > Tommi or someone familiat with media/ should probably comment as well. *familiar
The CQ bit was checked by eugenis@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
hans@chromium.org changed reviewers: + jrummell@chromium.org
+jrummell for more owners
https://codereview.chromium.org/2858383002/diff/1/media/audio/audio_low_laten... File media/audio/audio_low_latency_input_output_unittest.cc (right): https://codereview.chromium.org/2858383002/diff/1/media/audio/audio_low_laten... media/audio/audio_low_latency_input_output_unittest.cc:49: namespace { what about moving this anonymous namespace into media instead? That seems to be a common pattern to avoid repeating the namespace that the code in the anonymous namespace, is for.
https://codereview.chromium.org/2858383002/diff/1/media/audio/audio_unittest_... File media/audio/audio_unittest_util.h (right): https://codereview.chromium.org/2858383002/diff/1/media/audio/audio_unittest_... media/audio/audio_unittest_util.h:26: namespace media { nit: Typically namespace statements have a blank line before and after them. The only exception I've used is for class forward definitions (e.g. namespace base { /n class foo; /n class bar; /n }). However, I have no strong opinion on this is a header file.
PTAL I've also added a few empty lines around namespace declarations. https://codereview.chromium.org/2858383002/diff/1/media/audio/audio_low_laten... File media/audio/audio_low_latency_input_output_unittest.cc (right): https://codereview.chromium.org/2858383002/diff/1/media/audio/audio_low_laten... media/audio/audio_low_latency_input_output_unittest.cc:49: namespace { On 2017/05/10 17:54:02, tommi - chröme wrote: > what about moving this anonymous namespace into media instead? That seems to be > a common pattern to avoid repeating the namespace that the code in the anonymous > namespace, is for. Yes, that's a lot better!
lgtm
The CQ bit was checked by eugenis@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from hans@chromium.org Link to the patchset: https://codereview.chromium.org/2858383002/#ps20001 (title: ".")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494441700053380,
"parent_rev": "bacba4a2fdd44230993debc124e900314573aa18", "commit_rev":
"97228865445e54c1dbdf9ea04f3ad4b900451af9"}
Message was sent while issue was closed.
Description was changed from ========== Move one test in an anonymous namespace. This avoids ODR violation on media::MockAudioManager. BUG=709536 R=tommi@chromium.org,hans@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Move one test in an anonymous namespace. This avoids ODR violation on media::MockAudioManager. BUG=709536 R=tommi@chromium.org,hans@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2858383002 Cr-Commit-Position: refs/heads/master@{#470708} Committed: https://chromium.googlesource.com/chromium/src/+/97228865445e54c1dbdf9ea04f3a... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/97228865445e54c1dbdf9ea04f3a... |
