Ignore Return and Cmd+Return in the omnibox if no text has been entered.

Ignore Return and Cmd+Return in the omnibox if no text has been entered.

This fixes an issue where these inputs incorrectly cancel keyword search
mode.

BUG=513966
Review-Url: https://codereview.chromium.org/2858373002
Cr-Commit-Position: refs/heads/master@{#470975}
Committed: https://chromium.googlesource.com/chromium/src/+/b25681c4b38efe3f3a7a9bff034f9e83170b1d00

[Justin Donnelly, 2017-05-04 21:22:55]

The CQ bit was checked by jdonnelly@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 21:23:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Justin Donnelly, 2017-05-04 21:26:44]

jdonnelly@chromium.org changed reviewers:
+ ellyjones@chromium.org

[commit-bot: I haz the power, 2017-05-04 21:55:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 21:55:50]

Dry run: This issue passed the CQ dry run.

[Justin Donnelly, 2017-05-08 14:10:45]

Friendly ping.

[Elly Fong-Jones, 2017-05-11 15:32:59]

lgtm

[Justin Donnelly, 2017-05-11 15:59:11]

The CQ bit was checked by jdonnelly@chromium.org

[commit-bot: I haz the power, 2017-05-11 16:00:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 16:34:44]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494518351472460, "parent_rev":
"91e46a676a288cdcc42798867f9658d14e708268", "commit_rev":
"b25681c4b38efe3f3a7a9bff034f9e83170b1d00"}

[commit-bot: I haz the power, 2017-05-11 16:35:03]

Description was changed from

==========
Ignore Return and Cmd+Return in the omnibox if no text has been entered.

This fixes an issue where these inputs incorrectly cancel keyword search
mode.

BUG=513966
==========

to

==========
Ignore Return and Cmd+Return in the omnibox if no text has been entered.

This fixes an issue where these inputs incorrectly cancel keyword search
mode.

BUG=513966

Review-Url: https://codereview.chromium.org/2858373002
Cr-Commit-Position: refs/heads/master@{#470975}
Committed:
https://chromium.googlesource.com/chromium/src/+/b25681c4b38efe3f3a7a9bff034f...
==========

[commit-bot: I haz the power, 2017-05-11 16:35:04]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b25681c4b38efe3f3a7a9bff034f...

[Mark P, 2017-05-12 22:34:17]

On 2017/05/11 16:35:04, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/chromium/src/+/b25681c4b38efe3f3a7a9bff034f...

Drive-by:
This code seems fragile.

On Views platforms, I can enter keyword mode and press space and hit enter and
the enter is ignored.

With this change, it looks like we're only ignoring the enter if the text is
exactly empty; no whitespace allowed.

--mark

[Mark P, 2017-05-12 22:35:46]

Description was changed from

==========
Ignore Return and Cmd+Return in the omnibox if no text has been entered.

This fixes an issue where these inputs incorrectly cancel keyword search
mode.

BUG=513966

Review-Url: https://codereview.chromium.org/2858373002
Cr-Commit-Position: refs/heads/master@{#470975}
Committed:
https://chromium.googlesource.com/chromium/src/+/b25681c4b38efe3f3a7a9bff034f...
==========

to

==========
Ignore Return and Cmd+Return in the omnibox if no text has been entered.

This fixes an issue where these inputs incorrectly cancel keyword search
mode.

BUG=513966

Review-Url: https://codereview.chromium.org/2858373002
Cr-Commit-Position: refs/heads/master@{#470975}
Committed:
https://chromium.googlesource.com/chromium/src/+/b25681c4b38efe3f3a7a9bff034f...
==========