Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1704)

Unified Diff: tools/dom/scripts/dartdomgenerator.py

Issue 2858323003: Format dart:html and related generated files on output (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dom/scripts/dartdomgenerator.py
diff --git a/tools/dom/scripts/dartdomgenerator.py b/tools/dom/scripts/dartdomgenerator.py
index 6459e45c7e815df2f0d065a30e9a0ab7a70139f6..adae8e01482496fbbeefd8ba5e6be0609d8f9952 100755
--- a/tools/dom/scripts/dartdomgenerator.py
+++ b/tools/dom/scripts/dartdomgenerator.py
@@ -26,7 +26,7 @@ ply_dir = os.path.join(third_party_dir, 'ply')
# is dart-git/dart/third_party
if not os.path.exists(ply_dir):
# For Dartium (ply directory is dartium-git/src/third_party/ply) third_party
- # location is dartium-git/src/third_party
+ # location is dartium-git/src/third_party
third_party_dir = os.path.join(dart_dir, '..', 'third_party')
assert(os.path.exists(third_party_dir))
else:
@@ -227,6 +227,10 @@ def GenerateSingleFile(library_path, output_dir, generated_output_dir=None):
command = ' '.join(['cd', library_dir, ';',
copy_dart_script, output_dir, library_filename])
subprocess.call([command], shell=True)
+ prebuilt_dartfmt = os.path.join(utils.CheckedInSdkPath(), 'bin', 'dartfmt')
+ sdk_file = os.path.join(library_dir, output_dir, library_filename)
+ formatCommand = ' '.join([prebuilt_dartfmt, '-w', sdk_file])
+ subprocess.call([formatCommand], shell=True)
terry 2017/05/05 06:54:31 Looks good to me, although I think we'll want to d
terry 2017/05/05 06:59:01 You what this is fine just as it is. This is a sm
def UpdateCssProperties():
"""Regenerate the CssStyleDeclaration template file with the current CSS
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698