Format dart:html and related generated files on output

tools/dom/scripts/dartdomgenerator.py

 #!/usr/bin/python
 # Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 """This is the entry point to create Dart APIs from the IDL database."""
 
 import css_code_generator
 import os
 import sys
 
 # Setup all paths to find our PYTHON code
 
 # dart_dir is the location of dart's enlistment dartium (dartium-git/src/dart)
 # and Dart (dart-git/dart).
 dart_dir = os.path.abspath(os.path.normpath(os.path.join(os.path.dirname(__file__), '..', '..', '..')))
 sys.path.insert(1, os.path.join(dart_dir, 'tools/dom/new_scripts'))
 sys.path.insert(1, os.path.join(dart_dir, 'third_party/WebCore/bindings/scripts'))
 
 # Dartium's third_party directory location is dartium-git/src/third_party
 # and Dart's third_party directory location is dart-git/dart/third_party.
 third_party_dir = os.path.join(dart_dir, 'third_party')
 
 ply_dir = os.path.join(third_party_dir, 'ply')
 # If ply directory found then we're a Dart enlistment; third_party location
 # is dart-git/dart/third_party
 if not os.path.exists(ply_dir):
   # For Dartium (ply directory is dartium-git/src/third_party/ply) third_party
-  # location is dartium-git/src/third_party 
+  # location is dartium-git/src/third_party
   third_party_dir = os.path.join(dart_dir, '..', 'third_party')
   assert(os.path.exists(third_party_dir))
 else:
   # It's Dart we need to make sure that tools in injected in our search path
   # because this is where idl_parser is located for a Dart enlistment.  Dartium
   # can figure out the tools directory because of the location of where the
   # scripts blink scripts are located.
   tools_dir = os.path.join(dart_dir, 'tools')
   sys.path.insert(1, tools_dir)
 
@@ skipping 180 matching lines @@
 
 def GenerateSingleFile(library_path, output_dir, generated_output_dir=None):
   library_dir = os.path.dirname(library_path)
   library_filename = os.path.basename(library_path)
   copy_dart_script = os.path.relpath('../../copy_dart.py',
       library_dir)
   output_dir = os.path.relpath(output_dir, library_dir)
   command = ' '.join(['cd', library_dir, ';',
                       copy_dart_script, output_dir, library_filename])
   subprocess.call([command], shell=True)
+  prebuilt_dartfmt = os.path.join(utils.CheckedInSdkPath(), 'bin', 'dartfmt')
+  sdk_file = os.path.join(library_dir, output_dir, library_filename)
+  formatCommand = ' '.join([prebuilt_dartfmt, '-w', sdk_file])
+  subprocess.call([formatCommand], shell=True)
 

[terry, 2017/05/05 06:54:31]

Looks good to me, although I think we'll want to dartfmt the cached_patches.dart
file too.  Maybe this should be a function that is called after line 363 below.

[terry, 2017/05/05 06:59:01]

You what this is fine just as it is.  This is a small template that is squirted
out shouldn't be dartfmt'd until after generate_patches.py is run which is much
later after Dartium is built.  You could add this code to generate_patches.py to
dartfmt the cached_patches.dart file after its really generated.

 def UpdateCssProperties():
   """Regenerate the CssStyleDeclaration template file with the current CSS
   properties."""
   _logger.info('Updating Css Properties.')
   css_code_generator.GenerateCssTemplateFile()
 
 CACHED_PATCHES = """
 // START_OF_CACHED_PATCHES
 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
@@ skipping 126 matching lines @@
         os.path.join('..', '..', '..', 'sdk', 'lib', '_blink', 'dartium'))
 
   print '\nGenerating single file %s seconds' % round(time.time() - file_generation_start_time, 2)
 
   end_time = time.time()
 
   print '\nDone (dartdomgenerator) %s seconds' % round(end_time - start_time, 2)
 
 if __name__ == '__main__':
   sys.exit(main())