Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2858323003: Format dart:html and related generated files on output (Closed)

Created:
3 years, 7 months ago by Alan Knight
Modified:
3 years, 7 months ago
Reviewers:
terry, Jacob
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M tools/dom/scripts/dartdomgenerator.py View 2 chunks +5 lines, -1 line 2 comments Download

Messages

Total messages: 8 (2 generated)
Alan Knight
3 years, 7 months ago (2017-05-05 01:07:48 UTC) #2
terry
lgtm just need to handle one more file. https://codereview.chromium.org/2858323003/diff/1/tools/dom/scripts/dartdomgenerator.py File tools/dom/scripts/dartdomgenerator.py (right): https://codereview.chromium.org/2858323003/diff/1/tools/dom/scripts/dartdomgenerator.py#newcode234 tools/dom/scripts/dartdomgenerator.py:234: Looks ...
3 years, 7 months ago (2017-05-05 06:54:31 UTC) #3
terry
lgtm https://codereview.chromium.org/2858323003/diff/1/tools/dom/scripts/dartdomgenerator.py File tools/dom/scripts/dartdomgenerator.py (right): https://codereview.chromium.org/2858323003/diff/1/tools/dom/scripts/dartdomgenerator.py#newcode234 tools/dom/scripts/dartdomgenerator.py:234: On 2017/05/05 06:54:31, terry wrote: > Looks good ...
3 years, 7 months ago (2017-05-05 06:59:01 UTC) #4
Jacob
lgtm
3 years, 7 months ago (2017-05-05 16:04:00 UTC) #5
Alan Knight
Committed patchset #1 (id:1) manually as cedd8a6854206f32ecd3a458ba1716ef9760171c (presubmit successful).
3 years, 7 months ago (2017-05-05 17:09:08 UTC) #7
Alan Knight
3 years, 7 months ago (2017-05-05 17:09:14 UTC) #8
Message was sent while issue was closed.
Formatting cached_patches looks simple except it's not clear where to get
dartfmt from, or if we can even rely on it being there. I'll leave that for
another CL.

Powered by Google App Engine
This is Rietveld 408576698