Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(849)

Issue 2858313002: Refactored AppMenuAnimation (Closed)

Created:
3 years, 7 months ago by spqchan
Modified:
3 years, 7 months ago
Reviewers:
msw
CC:
chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactored AppMenuAnimation Refactored and moved AppMenuAnimation out of Views so that it can be used in cross platforms. AppMenuAnimation no longer paints the dot, instead it will handle the animation and delegate the painting to AppMenuAnimationDelegate. BUG=704786 Review-Url: https://codereview.chromium.org/2858313002 Cr-Commit-Position: refs/heads/master@{#469885} Committed: https://chromium.googlesource.com/chromium/src/+/6dc6477fbfd23d601d72dc1ad941699c65a47353

Patch Set 1 #

Patch Set 2 : Add comments #

Total comments: 14

Patch Set 3 : Fixes for msw #

Total comments: 2

Patch Set 4 : Fix for msw #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -319 lines) Patch
M chrome/browser/ui/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/toolbar/app_menu_animation.h View 1 2 6 chunks +20 lines, -9 lines 0 comments Download
A + chrome/browser/ui/toolbar/app_menu_animation.cc View 1 2 3 6 chunks +18 lines, -15 lines 0 comments Download
D chrome/browser/ui/views/toolbar/app_menu_animation.h View 1 chunk +0 lines, -89 lines 0 comments Download
D chrome/browser/ui/views/toolbar/app_menu_animation.cc View 1 chunk +0 lines, -186 lines 0 comments Download
M chrome/browser/ui/views/toolbar/app_menu_button.h View 1 2 4 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/toolbar/app_menu_button.cc View 1 2 4 chunks +18 lines, -11 lines 0 comments Download

Messages

Total messages: 27 (20 generated)
spqchan
Hey msw, PTAL. I’m moving this out of views so that this can also be ...
3 years, 7 months ago (2017-05-04 21:24:04 UTC) #15
msw
Thanks for pointing me at the mac cl too, that's helpful. Mostly lg, but I ...
3 years, 7 months ago (2017-05-05 18:47:39 UTC) #16
spqchan
Thanks for pointing out using Skia on Cocoa, I wasn't aware that we have something ...
3 years, 7 months ago (2017-05-05 21:20:54 UTC) #19
msw
lgtm, fingers crossed someday we'll ship Views on Mac! https://codereview.chromium.org/2858313002/diff/60001/chrome/browser/ui/toolbar/app_menu_animation.cc File chrome/browser/ui/toolbar/app_menu_animation.cc (right): https://codereview.chromium.org/2858313002/diff/60001/chrome/browser/ui/toolbar/app_menu_animation.cc#newcode51 chrome/browser/ui/toolbar/app_menu_animation.cc:51: ...
3 years, 7 months ago (2017-05-05 21:26:25 UTC) #20
spqchan
Thanks! https://codereview.chromium.org/2858313002/diff/60001/chrome/browser/ui/toolbar/app_menu_animation.cc File chrome/browser/ui/toolbar/app_menu_animation.cc (right): https://codereview.chromium.org/2858313002/diff/60001/chrome/browser/ui/toolbar/app_menu_animation.cc#newcode51 chrome/browser/ui/toolbar/app_menu_animation.cc:51: // The radius of each dot in the ...
3 years, 7 months ago (2017-05-05 21:37:34 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858313002/80001
3 years, 7 months ago (2017-05-05 21:38:56 UTC) #24
commit-bot: I haz the power
3 years, 7 months ago (2017-05-06 19:23:32 UTC) #27
Message was sent while issue was closed.
Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/6dc6477fbfd23d601d72dc1ad941...

Powered by Google App Engine
This is Rietveld 408576698