Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 2858273002: GN: Fix single-file compilations in VS2017 projects (Closed)

Created:
3 years, 7 months ago by NGG
Modified:
3 years, 7 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, Dirk Pranke, tfarina, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Fix single-file compilations in VS2017 projects Setting the "WindowsTargetPlatformVersion" XML element seems to be necessary in VS2017. Single-file compilations do not work without it. It does not cause any problems in older VS versions. R=brettw@chromium.org BUG= Review-Url: https://codereview.chromium.org/2858273002 Cr-Commit-Position: refs/heads/master@{#472272} Committed: https://chromium.googlesource.com/chromium/src/+/d77555bcaf03f30f100c8ac72d598d14ef63153f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/gn/visual_studio_writer.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858273002/1
3 years, 7 months ago (2017-05-16 07:51:34 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 7 months ago (2017-05-16 07:51:37 UTC) #4
Dirk Pranke
lgtm
3 years, 7 months ago (2017-05-16 22:37:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858273002/1
3 years, 7 months ago (2017-05-16 22:39:44 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 00:56:19 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d77555bcaf03f30f100c8ac72d59...

Powered by Google App Engine
This is Rietveld 408576698