Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 2858233002: Android: Fix generate_gradle.py (Closed)

Created:
3 years, 7 months ago by Peter Wen
Modified:
3 years, 7 months ago
Reviewers:
sakal-chromium, agrieve
CC:
chromium-reviews, mikecase+watch_chromium.org, nyquist+watch_chromium.org, jbudorick+watch_chromium.org, wnwen+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Android: Fix generate_gradle.py Bugs causing split-project and use-gradle-resources to not work correctly. Also fix the jinja template. BUG=620034 Review-Url: https://codereview.chromium.org/2858233002 Cr-Commit-Position: refs/heads/master@{#469372} Committed: https://chromium.googlesource.com/chromium/src/+/f011a78f3f93e0f52b89b29a4b40b2e2f879733c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M build/android/gradle/android.jinja View 1 chunk +1 line, -1 line 0 comments Download
M build/android/gradle/generate_gradle.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
Peter Wen
Hi Sami, PTAL.
3 years, 7 months ago (2017-05-04 10:24:13 UTC) #2
sakal-chromium
lgtm
3 years, 7 months ago (2017-05-04 11:06:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858233002/1
3 years, 7 months ago (2017-05-04 11:25:01 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 7 months ago (2017-05-04 11:25:03 UTC) #10
Peter Wen
+agrieve@ for committer.
3 years, 7 months ago (2017-05-04 11:25:49 UTC) #12
agrieve
On 2017/05/04 11:25:49, Peter Wen wrote: > +agrieve@ for committer. lgtm
3 years, 7 months ago (2017-05-04 17:16:05 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858233002/1
3 years, 7 months ago (2017-05-04 17:28:17 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 17:35:48 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f011a78f3f93e0f52b89b29a4b40...

Powered by Google App Engine
This is Rietveld 408576698