Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1196)

Issue 2858213003: (fix landed) Revert of Mark a FirstRunIntegrationTest flaky (Closed)

Created:
3 years, 7 months ago by findit-for-me
Modified:
3 years, 7 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Mark a FirstRunIntegrationTest flaky (patchset #1 id:1 of https://codereview.chromium.org/2863653002/ ) Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 469356 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2NiYjI3NTNjZmI4YjU0YzAxYjE2M2VmN2U0NDNiOTVhNWY1NzBjNzUM Original issue's description: > Mark a FirstRunIntegrationTest flaky > > FirstRunIntegrationTest.testDefaultSearchEngine_ShowExisting was > recently added by https://codereview.chromium.org/2844323003. > > However it's been consistently failing on Lollipop Phone Tester, and > flakily failing on other Android bots, so this patch disables it. > > BUG=718461 > TBR=dfalcantara > NOTRY=true > SKIPTREECHECKS=true > > Review-Url: https://codereview.chromium.org/2863653002 > Cr-Commit-Position: refs/heads/master@{#469356} > Committed: https://chromium.googlesource.com/chromium/src/+/cbb2753cfb8b54c01b163ef7e443b95a5f570c75 TBR=dfalcantara@chromium.org,johnme@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=718461

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/firstrun/FirstRunIntegrationTest.java View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
findit-for-me
Created Revert of Mark a FirstRunIntegrationTest flaky
3 years, 7 months ago (2017-05-04 18:10:09 UTC) #1
findit-for-me
Sheriffs: Please confirm and "Quick L-G-T-M & CQ" this revert if it is correct. If ...
3 years, 7 months ago (2017-05-04 18:10:11 UTC) #3
gone
A fix was already landed.
3 years, 7 months ago (2017-05-04 18:15:56 UTC) #5
stgao
3 years, 7 months ago (2017-05-11 17:32:57 UTC) #6
Message was sent while issue was closed.
On 2017/05/04 18:15:56, OOO (dfalcantara) wrote:
> A fix was already landed.

For record, the fixing CL is https://codereview.chromium.org/2861003002

Powered by Google App Engine
This is Rietveld 408576698