Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2858213002: Clean up base/process/process_metrics_linux.cc. (Closed)

Created:
3 years, 7 months ago by Lei Zhang
Modified:
3 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, danakj+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up base/process/process_metrics_linux.cc. - Use more StringPieces and C++11. - Merge some repeated code. - Fix nits. Review-Url: https://codereview.chromium.org/2858213002 Cr-Commit-Position: refs/heads/master@{#469404} Committed: https://chromium.googlesource.com/chromium/src/+/bc11dd614b1aa24a89e2ba977afbe01ad269c1bc

Patch Set 1 #

Patch Set 2 : more #

Patch Set 3 : constexpr is too much #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -159 lines) Patch
M base/process/process_metrics.h View 1 2 3 chunks +6 lines, -4 lines 0 comments Download
M base/process/process_metrics_linux.cc View 1 2 26 chunks +143 lines, -155 lines 0 comments Download

Messages

Total messages: 19 (15 generated)
Lei Zhang
3 years, 7 months ago (2017-05-04 17:37:41 UTC) #13
Mark Mentovai
This is generally a bit better! LGTM, thanks for the cleanup.
3 years, 7 months ago (2017-05-04 17:41:48 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858213002/60001
3 years, 7 months ago (2017-05-04 18:50:11 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 18:55:58 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/bc11dd614b1aa24a89e2ba977afb...

Powered by Google App Engine
This is Rietveld 408576698