Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1104)

Unified Diff: media/gpu/gpu_video_encode_accelerator_factory.h

Issue 2858193002: Refactor: Extract gpu_video_encode_accelerator_factory. (Closed)
Patch Set: address kcwu's comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/gpu/gpu_video_encode_accelerator_factory.h
diff --git a/media/gpu/gpu_video_encode_accelerator_factory.h b/media/gpu/gpu_video_encode_accelerator_factory.h
new file mode 100644
index 0000000000000000000000000000000000000000..242df870921d9637311354dcf93d706bb461ae3b
--- /dev/null
+++ b/media/gpu/gpu_video_encode_accelerator_factory.h
@@ -0,0 +1,37 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef MEDIA_GPU_GPU_VIDEO_ENCODE_ACCELERATOR_FACTORY_H_
+#define MEDIA_GPU_GPU_VIDEO_ENCODE_ACCELERATOR_FACTORY_H_
+
+#include <memory>
+
+#include "gpu/command_buffer/service/gpu_preferences.h"
+#include "media/gpu/media_gpu_export.h"
+#include "media/video/video_encode_accelerator.h"
+
+namespace media {
+
+class MEDIA_GPU_EXPORT GpuVideoEncodeAcceleratorFactory {
+ public:
+ GpuVideoEncodeAcceleratorFactory() = default;
+
+ std::unique_ptr<VideoEncodeAccelerator> CreateVEA(
+ VideoPixelFormat input_format,
Pawel Osciak 2017/05/15 01:28:51 Could this be static? Please also add short docs t
Owen Lin 2017/05/16 07:35:04 Done.
+ const gfx::Size& input_visible_size,
+ VideoCodecProfile output_profile,
+ uint32_t initial_bitrate,
+ VideoEncodeAccelerator::Client* client,
+ const gpu::GpuPreferences& gpu_perferences);
+
+ VideoEncodeAccelerator::SupportedProfiles GetSupportedProfiles(
+ const gpu::GpuPreferences& gpu_preferences);
Pawel Osciak 2017/05/15 01:28:51 And this as well?
Owen Lin 2017/05/16 07:35:05 Done.
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(GpuVideoEncodeAcceleratorFactory);
Pawel Osciak 2017/05/15 01:28:51 Perhaps DISALLOW_IMPLICIT_CONSTRUCTORS() ?
Owen Lin 2017/05/16 07:35:05 Done.
+};
+
+} // namespace media
+
+#endif // MEDIA_GPU_GPU_VIDEO_ENCODE_ACCELERATOR_FACTORY_H_

Powered by Google App Engine
This is Rietveld 408576698