Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2858193002:
Refactor: Extract gpu_video_encode_accelerator_factory. (Closed)
DescriptionRefactor: Extract gpu_video_encode_accelerator_factory.
TEST=Run vea_unittest on Kevin
BUG=b:32692654
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2858193002
Cr-Commit-Position: refs/heads/master@{#473144}
Committed: https://chromium.googlesource.com/chromium/src/+/58861d62211639b34bb40304c68dd7f8e85a6024
Patch Set 1 #
Total comments: 14
Patch Set 2 : address kcwu's comments #
Total comments: 29
Patch Set 3 : Address Pawel's review comments. #
Total comments: 4
Patch Set 4 : address nits #Patch Set 5 : Rebase #Patch Set 6 : Fix compiling error on Windows #Patch Set 7 : Try Again. Fix compiling errors on Windows. #
Messages
Total messages: 26 (12 generated)
Description was changed from ========== Refactor: Extract gpu_video_encode_accelerator_factory. TEST=Run vea_unittest on Kevin BUG=b:32692654 ========== to ========== Refactor: Extract gpu_video_encode_accelerator_factory. TEST=Run vea_unittest on Kevin BUG=b:32692654 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
owenlin@chromium.org changed reviewers: + kcwu@chromium.org, posciak@chromium.org
PTAL. Thank you.
https://codereview.chromium.org/2858193002/diff/1/media/gpu/gpu_video_encode_... File media/gpu/gpu_video_encode_accelerator_factory.cc (right): https://codereview.chromium.org/2858193002/diff/1/media/gpu/gpu_video_encode_... media/gpu/gpu_video_encode_accelerator_factory.cc:1: // Copyright 2016 The Chromium Authors. All rights reserved. 2017 https://codereview.chromium.org/2858193002/diff/1/media/gpu/gpu_video_encode_... media/gpu/gpu_video_encode_accelerator_factory.cc:8: #include "gpu/command_buffer/service/gpu_preferences.h" already in gpu_video_encode_accelerator_factory.h https://codereview.chromium.org/2858193002/diff/1/media/gpu/gpu_video_encode_... media/gpu/gpu_video_encode_accelerator_factory.cc:10: #include "media/gpu/media_gpu_export.h" already in gpu_video_encode_accelerator_factory.h https://codereview.chromium.org/2858193002/diff/1/media/gpu/gpu_video_encode_... media/gpu/gpu_video_encode_accelerator_factory.cc:72: static std::vector<VEAFactoryFunction> GetVEAFactoryFunctions( This is in unnamed namespace, no need to specify "static" again? https://codereview.chromium.org/2858193002/diff/1/media/gpu/gpu_video_encode_... File media/gpu/gpu_video_encode_accelerator_factory.h (right): https://codereview.chromium.org/2858193002/diff/1/media/gpu/gpu_video_encode_... media/gpu/gpu_video_encode_accelerator_factory.h:1: // Copyright 2016 The Chromium Authors. All rights reserved. 2017 https://codereview.chromium.org/2858193002/diff/1/media/gpu/gpu_video_encode_... media/gpu/gpu_video_encode_accelerator_factory.h:19: virtual ~GpuVideoEncodeAcceleratorFactory() = default; dtor could be removed? at least no need for "virtual" IIUC. https://codereview.chromium.org/2858193002/diff/1/media/gpu/ipc/service/gpu_v... File media/gpu/ipc/service/gpu_video_encode_accelerator.cc (right): https://codereview.chromium.org/2858193002/diff/1/media/gpu/ipc/service/gpu_v... media/gpu/ipc/service/gpu_video_encode_accelerator.cc:169: // Try all possible encoders and use the first successful encoder. Remove this out of date comment.
Please take another look, thank you. https://codereview.chromium.org/2858193002/diff/1/media/gpu/gpu_video_encode_... File media/gpu/gpu_video_encode_accelerator_factory.cc (right): https://codereview.chromium.org/2858193002/diff/1/media/gpu/gpu_video_encode_... media/gpu/gpu_video_encode_accelerator_factory.cc:1: // Copyright 2016 The Chromium Authors. All rights reserved. On 2017/05/05 09:31:17, kcwu wrote: > 2017 Done. https://codereview.chromium.org/2858193002/diff/1/media/gpu/gpu_video_encode_... media/gpu/gpu_video_encode_accelerator_factory.cc:8: #include "gpu/command_buffer/service/gpu_preferences.h" On 2017/05/05 09:31:17, kcwu wrote: > already in gpu_video_encode_accelerator_factory.h Done. https://codereview.chromium.org/2858193002/diff/1/media/gpu/gpu_video_encode_... media/gpu/gpu_video_encode_accelerator_factory.cc:10: #include "media/gpu/media_gpu_export.h" On 2017/05/05 09:31:17, kcwu wrote: > already in gpu_video_encode_accelerator_factory.h Done. https://codereview.chromium.org/2858193002/diff/1/media/gpu/gpu_video_encode_... media/gpu/gpu_video_encode_accelerator_factory.cc:72: static std::vector<VEAFactoryFunction> GetVEAFactoryFunctions( On 2017/05/05 09:31:17, kcwu wrote: > This is in unnamed namespace, no need to specify "static" again? Done. https://codereview.chromium.org/2858193002/diff/1/media/gpu/gpu_video_encode_... File media/gpu/gpu_video_encode_accelerator_factory.h (right): https://codereview.chromium.org/2858193002/diff/1/media/gpu/gpu_video_encode_... media/gpu/gpu_video_encode_accelerator_factory.h:1: // Copyright 2016 The Chromium Authors. All rights reserved. On 2017/05/05 09:31:17, kcwu wrote: > 2017 Done. https://codereview.chromium.org/2858193002/diff/1/media/gpu/gpu_video_encode_... media/gpu/gpu_video_encode_accelerator_factory.h:19: virtual ~GpuVideoEncodeAcceleratorFactory() = default; On 2017/05/05 09:31:17, kcwu wrote: > dtor could be removed? at least no need for "virtual" IIUC. Done. https://codereview.chromium.org/2858193002/diff/1/media/gpu/ipc/service/gpu_v... File media/gpu/ipc/service/gpu_video_encode_accelerator.cc (right): https://codereview.chromium.org/2858193002/diff/1/media/gpu/ipc/service/gpu_v... media/gpu/ipc/service/gpu_video_encode_accelerator.cc:169: // Try all possible encoders and use the first successful encoder. On 2017/05/05 09:31:17, kcwu wrote: > Remove this out of date comment. > Done.
lgtm
https://codereview.chromium.org/2858193002/diff/20001/media/gpu/gpu_video_enc... File media/gpu/gpu_video_encode_accelerator_factory.cc (right): https://codereview.chromium.org/2858193002/diff/20001/media/gpu/gpu_video_enc... media/gpu/gpu_video_encode_accelerator_factory.cc:32: scoped_refptr<V4L2Device> device = V4L2Device::Create(); perhaps auto? https://codereview.chromium.org/2858193002/diff/20001/media/gpu/gpu_video_enc... File media/gpu/gpu_video_encode_accelerator_factory.h (right): https://codereview.chromium.org/2858193002/diff/20001/media/gpu/gpu_video_enc... media/gpu/gpu_video_encode_accelerator_factory.h:21: VideoPixelFormat input_format, Could this be static? Please also add short docs to the methods. https://codereview.chromium.org/2858193002/diff/20001/media/gpu/gpu_video_enc... media/gpu/gpu_video_encode_accelerator_factory.h:29: const gpu::GpuPreferences& gpu_preferences); And this as well? https://codereview.chromium.org/2858193002/diff/20001/media/gpu/gpu_video_enc... media/gpu/gpu_video_encode_accelerator_factory.h:32: DISALLOW_COPY_AND_ASSIGN(GpuVideoEncodeAcceleratorFactory); Perhaps DISALLOW_IMPLICIT_CONSTRUCTORS() ? https://codereview.chromium.org/2858193002/diff/20001/media/gpu/ipc/service/g... File media/gpu/ipc/service/gpu_video_encode_accelerator.cc (right): https://codereview.chromium.org/2858193002/diff/20001/media/gpu/ipc/service/g... media/gpu/ipc/service/gpu_video_encode_accelerator.cc:173: DLOG(ERROR) << __func__ << " VEA initialization failed"; "Could not create VEA". If we don't support HW encoding on a platform, this would be normal, but could be misunderstood as error. On the other hand, it may be useful to distinguish between not creating a VEA at all (if one is not supported) and failures to initialize. For that perhaps we could have a separate message for failed Initialize() in the factory please? https://codereview.chromium.org/2858193002/diff/20001/media/gpu/ipc/service/g... media/gpu/ipc/service/gpu_video_encode_accelerator.cc:188: DLOG(ERROR) << "Failed spawning encoder worker thread."; Should we drop encoder_, filter_ and reset encoder_task_runner_ back to main here? Or we could maybe alternatively Start() before the TryToSetupEncodeOnSeparateThread if(). https://codereview.chromium.org/2858193002/diff/20001/media/gpu/video_encode_... File media/gpu/video_encode_accelerator_unittest.cc (right): https://codereview.chromium.org/2858193002/diff/20001/media/gpu/video_encode_... media/gpu/video_encode_accelerator_unittest.cc:1137: if (!g_fake_encoder) { I'm wondering if this should also use be using the verify_output_ flag... My personal preference would be yes... https://codereview.chromium.org/2858193002/diff/20001/media/gpu/video_encode_... media/gpu/video_encode_accelerator_unittest.cc:1162: // Helper function to create VEA Nit: dot at the end of sentence. https://codereview.chromium.org/2858193002/diff/20001/media/gpu/video_encode_... media/gpu/video_encode_accelerator_unittest.cc:1169: const gpu::GpuPreferences& gpu_perferences) { s/gpu_perferences/gpu_preferences/ https://codereview.chromium.org/2858193002/diff/20001/media/gpu/video_encode_... media/gpu/video_encode_accelerator_unittest.cc:1175: return encoder->Initialize(input_format, input_visible_size, output_profile, Would this perhaps be a bit more readable? if (encoder->Initialize()) { return encoder; } return nullptr; https://codereview.chromium.org/2858193002/diff/20001/media/gpu/video_encode_... media/gpu/video_encode_accelerator_unittest.cc:1200: LOG(ERROR) << "VideoEncodeAccelerator::Initialize() failed"; Failed creating a VideoEncodeAccelerator. https://codereview.chromium.org/2858193002/diff/20001/media/gpu/video_encode_... media/gpu/video_encode_accelerator_unittest.cc:1210: if (verify_output_ && !g_fake_encoder) I'm wondering if we should move this to be in the same place together with creating stream_validator_, or move stream_validator_ creation here? https://codereview.chromium.org/2858193002/diff/20001/media/gpu/video_encode_... media/gpu/video_encode_accelerator_unittest.cc:1816: LOG(ERROR) << "VideoEncodeAccelerator::Initialize() failed"; Failed creating a VideoEncodeAccelerator.
https://codereview.chromium.org/2858193002/diff/20001/media/gpu/gpu_video_enc... File media/gpu/gpu_video_encode_accelerator_factory.cc (right): https://codereview.chromium.org/2858193002/diff/20001/media/gpu/gpu_video_enc... media/gpu/gpu_video_encode_accelerator_factory.cc:32: scoped_refptr<V4L2Device> device = V4L2Device::Create(); On 2017/05/15 01:28:51, Pawel Osciak wrote: > perhaps auto? Done. https://codereview.chromium.org/2858193002/diff/20001/media/gpu/gpu_video_enc... File media/gpu/gpu_video_encode_accelerator_factory.h (right): https://codereview.chromium.org/2858193002/diff/20001/media/gpu/gpu_video_enc... media/gpu/gpu_video_encode_accelerator_factory.h:21: VideoPixelFormat input_format, On 2017/05/15 01:28:51, Pawel Osciak wrote: > Could this be static? Please also add short docs to the methods. Done. https://codereview.chromium.org/2858193002/diff/20001/media/gpu/gpu_video_enc... media/gpu/gpu_video_encode_accelerator_factory.h:29: const gpu::GpuPreferences& gpu_preferences); On 2017/05/15 01:28:51, Pawel Osciak wrote: > And this as well? Done. https://codereview.chromium.org/2858193002/diff/20001/media/gpu/gpu_video_enc... media/gpu/gpu_video_encode_accelerator_factory.h:32: DISALLOW_COPY_AND_ASSIGN(GpuVideoEncodeAcceleratorFactory); On 2017/05/15 01:28:51, Pawel Osciak wrote: > Perhaps DISALLOW_IMPLICIT_CONSTRUCTORS() ? Done. https://codereview.chromium.org/2858193002/diff/20001/media/gpu/ipc/service/g... File media/gpu/ipc/service/gpu_video_encode_accelerator.cc (right): https://codereview.chromium.org/2858193002/diff/20001/media/gpu/ipc/service/g... media/gpu/ipc/service/gpu_video_encode_accelerator.cc:173: DLOG(ERROR) << __func__ << " VEA initialization failed"; On 2017/05/15 01:28:51, Pawel Osciak wrote: > "Could not create VEA". If we don't support HW encoding on a platform, this > would be normal, but could be misunderstood as error. On the other hand, it may > be useful to distinguish between not creating a VEA at all (if one is not > supported) and failures to initialize. For that perhaps we could have a separate > message for failed Initialize() in the factory please? Done. https://codereview.chromium.org/2858193002/diff/20001/media/gpu/ipc/service/g... media/gpu/ipc/service/gpu_video_encode_accelerator.cc:188: DLOG(ERROR) << "Failed spawning encoder worker thread."; On 2017/05/15 01:28:51, Pawel Osciak wrote: > Should we drop encoder_, filter_ and reset encoder_task_runner_ back to main > here? Or we could maybe alternatively Start() before the > TryToSetupEncodeOnSeparateThread if(). mmm.... I am not sure what's your concerns here. But I would prefer not to change the logic here for this CL. https://codereview.chromium.org/2858193002/diff/20001/media/gpu/video_encode_... File media/gpu/video_encode_accelerator_unittest.cc (right): https://codereview.chromium.org/2858193002/diff/20001/media/gpu/video_encode_... media/gpu/video_encode_accelerator_unittest.cc:1137: if (!g_fake_encoder) { On 2017/05/15 01:28:51, Pawel Osciak wrote: > I'm wondering if this should also use be using the verify_output_ flag... My > personal preference would be yes... I would prefer to do it in another CL, it is not relevant. Besides, there are two kinds of validate, stream validate, and quality validate. - stream validation is always enabled except for fake encoder. - quality validation is controlled by verify_output_. https://codereview.chromium.org/2858193002/diff/20001/media/gpu/video_encode_... media/gpu/video_encode_accelerator_unittest.cc:1162: // Helper function to create VEA On 2017/05/15 01:28:52, Pawel Osciak wrote: > Nit: dot at the end of sentence. Done. https://codereview.chromium.org/2858193002/diff/20001/media/gpu/video_encode_... media/gpu/video_encode_accelerator_unittest.cc:1169: const gpu::GpuPreferences& gpu_perferences) { On 2017/05/15 01:28:52, Pawel Osciak wrote: > s/gpu_perferences/gpu_preferences/ Done. https://codereview.chromium.org/2858193002/diff/20001/media/gpu/video_encode_... media/gpu/video_encode_accelerator_unittest.cc:1175: return encoder->Initialize(input_format, input_visible_size, output_profile, On 2017/05/15 01:28:51, Pawel Osciak wrote: > Would this perhaps be a bit more readable? > > if (encoder->Initialize()) { > return encoder; > } > > return nullptr; Done. https://codereview.chromium.org/2858193002/diff/20001/media/gpu/video_encode_... media/gpu/video_encode_accelerator_unittest.cc:1200: LOG(ERROR) << "VideoEncodeAccelerator::Initialize() failed"; On 2017/05/15 01:28:52, Pawel Osciak wrote: > Failed creating a VideoEncodeAccelerator. Done. https://codereview.chromium.org/2858193002/diff/20001/media/gpu/video_encode_... media/gpu/video_encode_accelerator_unittest.cc:1210: if (verify_output_ && !g_fake_encoder) On 2017/05/15 01:28:51, Pawel Osciak wrote: > I'm wondering if we should move this to be in the same place together with > creating stream_validator_, or move stream_validator_ creation here? Will do in another CL. https://codereview.chromium.org/2858193002/diff/20001/media/gpu/video_encode_... media/gpu/video_encode_accelerator_unittest.cc:1816: LOG(ERROR) << "VideoEncodeAccelerator::Initialize() failed"; On 2017/05/15 01:28:51, Pawel Osciak wrote: > Failed creating a VideoEncodeAccelerator. Done.
Thanks! lgtm % nits. https://codereview.chromium.org/2858193002/diff/20001/media/gpu/ipc/service/g... File media/gpu/ipc/service/gpu_video_encode_accelerator.cc (right): https://codereview.chromium.org/2858193002/diff/20001/media/gpu/ipc/service/g... media/gpu/ipc/service/gpu_video_encode_accelerator.cc:188: DLOG(ERROR) << "Failed spawning encoder worker thread."; On 2017/05/16 07:35:05, Owen Lin wrote: > On 2017/05/15 01:28:51, Pawel Osciak wrote: > > Should we drop encoder_, filter_ and reset encoder_task_runner_ back to main > > here? Or we could maybe alternatively Start() before the > > TryToSetupEncodeOnSeparateThread if(). > > mmm.... I am not sure what's your concerns here. But I would prefer not to > change the logic here for this CL. The issue here is that if starting the encoder thread fails, we keep encoder and everything else alive. Also, if Initialize() is run again, and succeeds on another encoder, we have encode_task_runner_ still assigned to io_task_runner_, instead of main, even if the new encoder failed TryToSetup...(). Also filter_ is still valid and assigned on the channel. Normally this class will likely be destroyed after Initialize() fails, but it would still be nice to do this just to prevent any unexpected behaviors. I am ok with doing this in another CL though. I think the simplest solution would be to move this to before TryToSetupEncodeOnSeparateThread(), then we wouldn't have to reset everything. https://codereview.chromium.org/2858193002/diff/20001/media/gpu/video_encode_... File media/gpu/video_encode_accelerator_unittest.cc (right): https://codereview.chromium.org/2858193002/diff/20001/media/gpu/video_encode_... media/gpu/video_encode_accelerator_unittest.cc:1137: if (!g_fake_encoder) { On 2017/05/16 07:35:05, Owen Lin wrote: > On 2017/05/15 01:28:51, Pawel Osciak wrote: > > I'm wondering if this should also use be using the verify_output_ flag... My > > personal preference would be yes... > > I would prefer to do it in another CL, it is not relevant. > > Besides, there are two kinds of validate, stream validate, and quality validate. > > - stream validation is always enabled except for fake encoder. > - quality validation is controlled by verify_output_. Acknowledged. https://codereview.chromium.org/2858193002/diff/40001/media/gpu/gpu_video_enc... File media/gpu/gpu_video_encode_accelerator_factory.h (right): https://codereview.chromium.org/2858193002/diff/40001/media/gpu/gpu_video_enc... media/gpu/gpu_video_encode_accelerator_factory.h:20: // VideoEncodeAccelerator::Initiailze() returns false. s/Initiailze/Initialize/ https://codereview.chromium.org/2858193002/diff/40001/media/gpu/gpu_video_enc... media/gpu/gpu_video_encode_accelerator_factory.h:29: // Gets the supported codec profiles for video encoding on the platforms. s/platforms/platform/
https://codereview.chromium.org/2858193002/diff/20001/media/gpu/ipc/service/g... File media/gpu/ipc/service/gpu_video_encode_accelerator.cc (right): https://codereview.chromium.org/2858193002/diff/20001/media/gpu/ipc/service/g... media/gpu/ipc/service/gpu_video_encode_accelerator.cc:188: DLOG(ERROR) << "Failed spawning encoder worker thread."; On 2017/05/18 04:33:37, Pawel Osciak wrote: > On 2017/05/16 07:35:05, Owen Lin wrote: > > On 2017/05/15 01:28:51, Pawel Osciak wrote: > > > Should we drop encoder_, filter_ and reset encoder_task_runner_ back to main > > > here? Or we could maybe alternatively Start() before the > > > TryToSetupEncodeOnSeparateThread if(). > > > > mmm.... I am not sure what's your concerns here. But I would prefer not to > > change the logic here for this CL. > > The issue here is that if starting the encoder thread fails, we keep encoder and > everything else alive. Also, if Initialize() is run again, and succeeds on > another encoder, we have encode_task_runner_ still assigned to io_task_runner_, > instead of main, even if the new encoder failed TryToSetup...(). Also filter_ is > still valid and assigned on the channel. > > Normally this class will likely be destroyed after Initialize() fails, but it > would still be nice to do this just to prevent any unexpected behaviors. I am ok > with doing this in another CL though. I think the simplest solution would be to > move this to before TryToSetupEncodeOnSeparateThread(), then we wouldn't have to > reset everything. Acknowledged. https://codereview.chromium.org/2858193002/diff/40001/media/gpu/gpu_video_enc... File media/gpu/gpu_video_encode_accelerator_factory.h (right): https://codereview.chromium.org/2858193002/diff/40001/media/gpu/gpu_video_enc... media/gpu/gpu_video_encode_accelerator_factory.h:20: // VideoEncodeAccelerator::Initiailze() returns false. On 2017/05/18 04:33:37, Pawel Osciak wrote: > s/Initiailze/Initialize/ Done. https://codereview.chromium.org/2858193002/diff/40001/media/gpu/gpu_video_enc... media/gpu/gpu_video_encode_accelerator_factory.h:29: // Gets the supported codec profiles for video encoding on the platforms. On 2017/05/18 04:33:37, Pawel Osciak wrote: > s/platforms/platform/ Done.
The CQ bit was checked by owenlin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from kcwu@chromium.org, posciak@chromium.org Link to the patchset: https://codereview.chromium.org/2858193002/#ps60001 (title: "address nits")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...) mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)
The CQ bit was checked by owenlin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from kcwu@chromium.org, posciak@chromium.org Link to the patchset: https://codereview.chromium.org/2858193002/#ps80001 (title: "Rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)
The CQ bit was checked by owenlin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from kcwu@chromium.org, posciak@chromium.org Link to the patchset: https://codereview.chromium.org/2858193002/#ps120001 (title: "Try Again. Fix compiling errors on Windows.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 120001, "attempt_start_ts": 1495181075650200,
"parent_rev": "d53897114431e77ccce2c40c8769c3d005b31688", "commit_rev":
"58861d62211639b34bb40304c68dd7f8e85a6024"}
Message was sent while issue was closed.
Description was changed from ========== Refactor: Extract gpu_video_encode_accelerator_factory. TEST=Run vea_unittest on Kevin BUG=b:32692654 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Refactor: Extract gpu_video_encode_accelerator_factory. TEST=Run vea_unittest on Kevin BUG=b:32692654 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2858193002 Cr-Commit-Position: refs/heads/master@{#473144} Committed: https://chromium.googlesource.com/chromium/src/+/58861d62211639b34bb40304c68d... ==========
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as https://chromium.googlesource.com/chromium/src/+/58861d62211639b34bb40304c68d... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
