Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2858153005: Fix extraneous beeps on empty page search. (Closed)

Created:
3 years, 7 months ago by Sigurður Ásgeirsson
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Fix extraneous beeps on empty page search. As of https://crrev.com/3ac612d592cd42355a432c8d307051d299d79768 a find-in-page can issue multiple "final updates" if the document changes. Each time a final update with zero results occurs, there is an audbible notification which is a nuisance beyond the first one. Particularly bothersome is that most or all pages cause a ding as you close them if they have an active find in page with zero results. BUG=682299 Review-Url: https://codereview.chromium.org/2839713002 Cr-Commit-Position: refs/heads/master@{#467417} (cherry picked from commit 59192dd2dd5d23372ca3ace498327f1c690e61ac) Review-Url: https://codereview.chromium.org/2858153005 . Cr-Commit-Position: refs/branch-heads/3071@{#419} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/b5cf4cfcefca6ace80f3b64dae5186f86092d54c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -3 lines) Patch
M chrome/browser/ui/find_bar/find_bar_controller.h View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/find_bar/find_bar_controller.cc View 2 chunks +17 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Sigurður Ásgeirsson
3 years, 7 months ago (2017-05-05 17:20:37 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b5cf4cfcefca6ace80f3b64dae5186f86092d54c.

Powered by Google App Engine
This is Rietveld 408576698