Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2858153003: [turbofan] Remove self-healing wrt. ChangeFloat64ToTagged. (Closed)

Created:
3 years, 7 months ago by Benedikt Meurer
Modified:
3 years, 7 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove self-healing wrt. ChangeFloat64ToTagged. Make sure that the input to ChangeFloat64ToTagged is definitely of type Number, because the operator cannot deal with non-Number inputs. R=jarin@chromium.org BUG=v8:5267 Review-Url: https://codereview.chromium.org/2858153003 Cr-Commit-Position: refs/heads/master@{#45087} Committed: https://chromium.googlesource.com/v8/v8/+/6b4e8c2114b04d3d9f39f4d7c49108ea4d56ae12

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -6 lines) Patch
M src/compiler/representation-change.cc View 2 chunks +19 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Benedikt Meurer
3 years, 7 months ago (2017-05-04 11:26:46 UTC) #1
Jarin
lgtm
3 years, 7 months ago (2017-05-04 11:28:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858153003/1
3 years, 7 months ago (2017-05-04 11:30:42 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 12:32:36 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/6b4e8c2114b04d3d9f39f4d7c49108ea4d5...

Powered by Google App Engine
This is Rietveld 408576698