Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2858143002: [refactor] - Use WebContents::FindFrameByFrameTreeNodeId() instead of manually searching all frames. (Closed)

Created:
3 years, 7 months ago by EhsanK
Modified:
3 years, 7 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[refactor] - Use WebContents::FindFrameByFrameTreeNodeId() instead of manually searching all frames. This CL removes a manual for-loop and replaces it with the public API specified for this purpose. BUG=NONE Review-Url: https://codereview.chromium.org/2858143002 Cr-Commit-Position: refs/heads/master@{#469245} Committed: https://chromium.googlesource.com/chromium/src/+/ba08eba0840cb3067a741650c0ffbc234c5f2515

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M extensions/browser/extension_navigation_throttle.cc View 1 chunk +3 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
EhsanK
PTAL. Thanks!
3 years, 7 months ago (2017-05-04 00:14:30 UTC) #6
lazyboy
lgtm, thanks!
3 years, 7 months ago (2017-05-04 01:27:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858143002/1
3 years, 7 months ago (2017-05-04 01:58:43 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 02:03:55 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ba08eba0840cb3067a741650c0ff...

Powered by Google App Engine
This is Rietveld 408576698