Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2858113002:
Use replicated container policy in remote frames (Closed)
DescriptionUse replicated container policy in remote frames
BUG=718160
Review-Url: https://codereview.chromium.org/2858113002
Cr-Commit-Position: refs/heads/master@{#469658}
Committed: https://chromium.googlesource.com/chromium/src/+/3a69e4860efab03bba98d13bbcf4883fae7a3bc0
Patch Set 1 #
Total comments: 2
Patch Set 2 : Remove null check #Messages
Total messages: 23 (14 generated)
The CQ bit was checked by iclelland@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
iclelland@chromium.org changed reviewers: + alexmos@chromium.org
+r alexmos, can you take a look?
LGTM
+r pfeldman, can you ptal as OWNER? Thanks
dcheng@chromium.org changed reviewers: + dcheng@chromium.org
https://codereview.chromium.org/2858113002/diff/1/third_party/WebKit/Source/w... File third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp (right): https://codereview.chromium.org/2858113002/diff/1/third_party/WebKit/Source/w... third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp:429: if (GetFrame() && GetFrame()->Owner()) Drive-by: don't null check GetFrame() here (it's derefenced on 431 with no guard anyway)
The CQ bit was checked by iclelland@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/05/04 21:36:32, dcheng wrote: > https://codereview.chromium.org/2858113002/diff/1/third_party/WebKit/Source/w... > File third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp (right): > > https://codereview.chromium.org/2858113002/diff/1/third_party/WebKit/Source/w... > third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp:429: if (GetFrame() && > GetFrame()->Owner()) > Drive-by: don't null check GetFrame() here (it's derefenced on 431 with no guard > anyway) dcheng -- Since you've taken a look, do you want to review as OWNER? (I neglected to actually add Pavel the first time)
https://codereview.chromium.org/2858113002/diff/1/third_party/WebKit/Source/w... File third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp (right): https://codereview.chromium.org/2858113002/diff/1/third_party/WebKit/Source/w... third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp:429: if (GetFrame() && GetFrame()->Owner()) On 2017/05/04 21:36:31, dcheng wrote: > Drive-by: don't null check GetFrame() here (it's derefenced on 431 with no guard > anyway) Done, thanks
lgtm
The CQ bit was checked by iclelland@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from alexmos@chromium.org Link to the patchset: https://codereview.chromium.org/2858113002/#ps20001 (title: "Remove null check")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493998425020110,
"parent_rev": "75082829aad93d623e621baf968eb6632c0bb009", "commit_rev":
"3a69e4860efab03bba98d13bbcf4883fae7a3bc0"}
Message was sent while issue was closed.
Description was changed from ========== Use replicated container policy in remote frames BUG=718160 ========== to ========== Use replicated container policy in remote frames BUG=718160 Review-Url: https://codereview.chromium.org/2858113002 Cr-Commit-Position: refs/heads/master@{#469658} Committed: https://chromium.googlesource.com/chromium/src/+/3a69e4860efab03bba98d13bbcf4... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/3a69e4860efab03bba98d13bbcf4... |
