Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2858093002: Upstream service worker `fetch` test to WPT (Closed)

Created:
3 years, 7 months ago by mike3
Modified:
3 years, 7 months ago
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, falken+watch_chromium.org, horo+watch_chromium.org, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, kinuko+serviceworker, michaeln, nhiroki, serviceworker-reviews, shimazu+serviceworker_chromium.org, tfarina, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream service worker `fetch` test to WPT **fetch-request-html-imports** Use HTTPS version of absolute URLs and schedule iframe element to be removed at the completion of the test. **fetch-request-resources** Extend the WPT version of this test with the novel aspects of the Chromium version: - assertions for the `redirect` attribute of the Request object - 1 additional test case for image resource requests - 2 additional test cases for stylesheet resource requests - 15 test cases for "fetch" requests - 6 test cases for audio resource requests Note that while the Chromium version also contains test cases for image resources loaded via CSS, equivalent tests are already present upstream (under the name `fetch-request-css-images.https.html`) and therefore do not need to be migrated. Chromium continues to fail the upstream version due to its additional assertions for the `integrity` attribute of the Request object. Due to this, it cannot be used as a substitute for the Chromium-specific version. Persist the Chromium-specific version under a new file name documenting its deprecated status. BUG=688116 R=mek@chromium.org Review-Url: https://codereview.chromium.org/2858093002 Cr-Commit-Position: refs/heads/master@{#469726} Committed: https://chromium.googlesource.com/chromium/src/+/be8f71f78b95b5d953e1f385120f9aa7f797ed0d

Patch Set 1 #

Total comments: 6

Patch Set 2 : Incorporate review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -355 lines) Patch
A + third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-request-html-imports.https.html View 1 2 chunks +7 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-request-resources.https.html View 1 11 chunks +70 lines, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/fetch-request-html-imports-iframe.html View 2 chunks +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/fetch-request-html-imports-worker.js View 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/fetch-request-resources-iframe.https.html View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/fetch-request-resources-worker.js View 1 chunk +1 line, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.fetch-request-resources.html View 1 1 chunk +5 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-request-html-imports.html View 1 chunk +0 lines, -61 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-request-resources.html View 1 chunk +0 lines, -236 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/fetch-request-html-imports-iframe.html View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/fetch-request-html-imports-worker.js View 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Marijn Kruisselbrink
lgtm, although it might be nice if there would be a bug associated whenever you ...
3 years, 7 months ago (2017-05-04 18:38:20 UTC) #1
mike3
All set, Mek. Thanks! https://codereview.chromium.org/2858093002/diff/1/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-request-html-imports.https.html File third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-request-html-imports.https.html (right): https://codereview.chromium.org/2858093002/diff/1/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-request-html-imports.https.html#newcode5 third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-request-html-imports.https.html:5: <script src="/common/get-host-info.sub.js?pipe=sub"></script> On 2017/05/04 18:38:19, ...
3 years, 7 months ago (2017-05-05 16:44:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858093002/20001
3 years, 7 months ago (2017-05-05 16:45:37 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 18:22:15 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/be8f71f78b95b5d953e1f385120f...

Powered by Google App Engine
This is Rietveld 408576698