Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2858043007: Ensure CATEGORY_LAUNCHER exists for MAIN intents for NTP inactivity/logging. (Closed)

Created:
3 years, 7 months ago by Ted C
Modified:
3 years, 7 months ago
Reviewers:
Theresa
CC:
chromium-reviews, asvitkine+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure CATEGORY_LAUNCHER exists for MAIN intents for NTP inactivity/logging. For the logging of main intent metrics and creating NTPs due to inactivity, we only want to do this if we believe the user came from the launcher. Chrome sends itself MAIN intents and those should not be counted towards this. We should follow up and remove dispatching MAIN intents to ourself as a followup, but this is a step towards the intent of this logging and behavior. Adds a test that if we get a MAIN intent without the launcher category, that we are not going to be waiting for a behavior to be logged via the main intent tracker. BUG=717754 Review-Url: https://codereview.chromium.org/2858043007 Cr-Commit-Position: refs/heads/master@{#469441} Committed: https://chromium.googlesource.com/chromium/src/+/c945299c463a8f795a59698927a2b541c0f25414

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -6 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java View 4 chunks +13 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/metrics/MainIntentBehaviorMetrics.java View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/metrics/MainIntentBehaviorMetricsIntegrationTest.java View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Ted C
PTAL
3 years, 7 months ago (2017-05-04 16:01:14 UTC) #2
Theresa
lgtm
3 years, 7 months ago (2017-05-04 16:36:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858043007/1
3 years, 7 months ago (2017-05-04 16:41:04 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/261720)
3 years, 7 months ago (2017-05-04 17:46:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858043007/20001
3 years, 7 months ago (2017-05-04 18:19:10 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 20:06:56 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c945299c463a8f795a59698927a2...

Powered by Google App Engine
This is Rietveld 408576698