Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Unified Diff: components/security_interstitials/core/ssl_error_ui.cc

Issue 2858043004: Support interstitials with no primary button (Closed)
Patch Set: Fix iOS CanGoBack implementation Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/security_interstitials/core/ssl_error_ui.cc
diff --git a/components/security_interstitials/core/ssl_error_ui.cc b/components/security_interstitials/core/ssl_error_ui.cc
index e438bc601e253184d008598b899f8cffeb7fb8bc..1cde12396de6f6c67c47c1b6c02f3e9d8175619b 100644
--- a/components/security_interstitials/core/ssl_error_ui.cc
+++ b/components/security_interstitials/core/ssl_error_ui.cc
@@ -69,6 +69,7 @@ void SSLErrorUI::PopulateStringsForHTML(base::DictionaryValue* load_time_data) {
// Shared values for both the overridable and non-overridable versions.
load_time_data->SetBoolean("bad_clock", false);
+ load_time_data->SetBoolean("hide_primary_button", false);
load_time_data->SetString("tabTitle",
l10n_util::GetStringUTF16(IDS_SSL_V2_TITLE));
load_time_data->SetString("heading",
@@ -95,6 +96,7 @@ void SSLErrorUI::PopulateOverridableStrings(
ssl_info_.cert.get(), request_url_);
load_time_data->SetBoolean("overridable", true);
+ load_time_data->SetBoolean("hide_primary_button", false);
load_time_data->SetString("explanationParagraph", error_info.details());
load_time_data->SetString(
"primaryButtonText",
@@ -113,6 +115,7 @@ void SSLErrorUI::PopulateNonOverridableStrings(
ssl_errors::ErrorInfo::NetErrorToErrorType(cert_error_);
load_time_data->SetBoolean("overridable", false);
+ load_time_data->SetBoolean("hide_primary_button", false);
load_time_data->SetString(
"explanationParagraph",
l10n_util::GetStringFUTF16(IDS_SSL_NONOVERRIDABLE_MORE, url));

Powered by Google App Engine
This is Rietveld 408576698