components/security_interstitials/core/safe_browsing_error_ui.cc - Issue 2858043004: Support interstitials with no primary button

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/security_interstitials/core/safe_browsing_error_ui.cc

Issue 2858043004: Support interstitials with no primary button (Closed)

Patch Set: Fix iOS CanGoBack implementation Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/security_interstitials/core/safe_browsing_error_ui.cc

diff --git a/components/security_interstitials/core/safe_browsing_error_ui.cc b/components/security_interstitials/core/safe_browsing_error_ui.cc

index 38566d65e6c5bbeecec6a36cd6b8ddaeb3c4f0bb..7b2ad57b6ee03534da4554929edaa53107a48e41 100644

--- a/components/security_interstitials/core/safe_browsing_error_ui.cc

+++ b/components/security_interstitials/core/safe_browsing_error_ui.cc

@@ -95,6 +95,7 @@ void SafeBrowsingErrorUI::PopulateStringsForHTML(

l10n_util::GetStringUTF16(IDS_SAFEBROWSING_OVERRIDABLE_SAFETY_BUTTON));

load_time_data->SetBoolean("overridable",

!display_options_.is_proceed_anyway_disabled);

+ load_time_data->SetBoolean("hide_primary_button", !controller_->CanGoBack());

switch (interstitial_reason_) {

case SB_REASON_MALWARE: