Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Unified Diff: ios/chrome/browser/interstitials/ios_chrome_controller_client.mm

Issue 2858043004: Support interstitials with no primary button (Closed)
Patch Set: Fix nits Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/interstitials/ios_chrome_controller_client.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/interstitials/ios_chrome_controller_client.mm
diff --git a/ios/chrome/browser/interstitials/ios_chrome_controller_client.mm b/ios/chrome/browser/interstitials/ios_chrome_controller_client.mm
index fa640eae5a9a29b6f868782bb1ddded14614fb95..143eceedbad12260d8759a09856c95aac84103ad 100644
--- a/ios/chrome/browser/interstitials/ios_chrome_controller_client.mm
+++ b/ios/chrome/browser/interstitials/ios_chrome_controller_client.mm
@@ -45,6 +45,10 @@ void IOSChromeControllerClient::GoBack() {
web_interstitial_->DontProceed();
}
+bool IOSChromeControllerClient::CanGoBack() {
+ return true;
rohitrao (ping after 24h) 2017/05/09 10:38:40 Is this meant to always be true, even if the under
edwardjung 2017/05/09 11:20:25 This was added primarily for webview but you're ri
edwardjung 2017/05/09 11:47:47 I found the equivalent and implemented here.
+}
+
void IOSChromeControllerClient::GoBackAfterNavigationCommitted() {
NOTREACHED();
}
« no previous file with comments | « ios/chrome/browser/interstitials/ios_chrome_controller_client.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698