Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: ios/chrome/browser/interstitials/ios_chrome_controller_client.mm

Issue 2858043004: Support interstitials with no primary button (Closed)
Patch Set: Fix nits Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ios/chrome/browser/interstitials/ios_chrome_controller_client.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ios/chrome/browser/interstitials/ios_chrome_controller_client.h" 5 #include "ios/chrome/browser/interstitials/ios_chrome_controller_client.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "components/security_interstitials/core/metrics_helper.h" 8 #include "components/security_interstitials/core/metrics_helper.h"
9 #include "ios/chrome/browser/application_context.h" 9 #include "ios/chrome/browser/application_context.h"
10 #include "ios/chrome/browser/browser_state/chrome_browser_state.h" 10 #include "ios/chrome/browser/browser_state/chrome_browser_state.h"
(...skipping 27 matching lines...) Expand all
38 38
39 void IOSChromeControllerClient::LaunchDateAndTimeSettings() { 39 void IOSChromeControllerClient::LaunchDateAndTimeSettings() {
40 NOTREACHED(); 40 NOTREACHED();
41 } 41 }
42 42
43 void IOSChromeControllerClient::GoBack() { 43 void IOSChromeControllerClient::GoBack() {
44 DCHECK(web_interstitial_); 44 DCHECK(web_interstitial_);
45 web_interstitial_->DontProceed(); 45 web_interstitial_->DontProceed();
46 } 46 }
47 47
48 bool IOSChromeControllerClient::CanGoBack() {
49 return true;
rohitrao (ping after 24h) 2017/05/09 10:38:40 Is this meant to always be true, even if the under
edwardjung 2017/05/09 11:20:25 This was added primarily for webview but you're ri
edwardjung 2017/05/09 11:47:47 I found the equivalent and implemented here.
50 }
51
48 void IOSChromeControllerClient::GoBackAfterNavigationCommitted() { 52 void IOSChromeControllerClient::GoBackAfterNavigationCommitted() {
49 NOTREACHED(); 53 NOTREACHED();
50 } 54 }
51 55
52 void IOSChromeControllerClient::Proceed() { 56 void IOSChromeControllerClient::Proceed() {
53 DCHECK(web_interstitial_); 57 DCHECK(web_interstitial_);
54 web_interstitial_->Proceed(); 58 web_interstitial_->Proceed();
55 } 59 }
56 60
57 void IOSChromeControllerClient::Reload() { 61 void IOSChromeControllerClient::Reload() {
(...skipping 14 matching lines...) Expand all
72 PrefService* IOSChromeControllerClient::GetPrefService() { 76 PrefService* IOSChromeControllerClient::GetPrefService() {
73 return ios::ChromeBrowserState::FromBrowserState( 77 return ios::ChromeBrowserState::FromBrowserState(
74 web_state_->GetBrowserState()) 78 web_state_->GetBrowserState())
75 ->GetPrefs(); 79 ->GetPrefs();
76 } 80 }
77 81
78 const std::string IOSChromeControllerClient::GetExtendedReportingPrefName() 82 const std::string IOSChromeControllerClient::GetExtendedReportingPrefName()
79 const { 83 const {
80 return std::string(); 84 return std::string();
81 } 85 }
OLDNEW
« no previous file with comments | « ios/chrome/browser/interstitials/ios_chrome_controller_client.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698