chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc - Issue 2858013002: PS - Showing permission prompt for activeTab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc

Issue 2858013002: PS - Showing permission prompt for activeTab (Closed)

Patch Set: Changed permission prompt message Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/active_tab_permission_granter_delegate_chromeos_unittest.cc ('k') | chrome/browser/chromeos/extensions/public_session_permission_helper.h » ('j') | chrome/browser/extensions/active_tab_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc

diff --git a/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc b/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc

index 92948d8182cedf311ee3577028911272c4b4b7f3..48ef2a1a56db06f8871f7bffb0e043519e7c3c9e 100644

--- a/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc

+++ b/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc

@@ -389,7 +389,9 @@ const char* const kSafePermissionStrings[] = {

// doesn't trigger a permission warning on install though, so blocking is

// somewhat at odds with the spirit of the API - however I presume the API

// design assumes user-installed extensions, which we don't have here.

- // "activeTab",

+ // Whitelisted because it's restricted now (asks user for permission the

+ // first time an extension tries to use it).

+ "activeTab",

// Schedule code to run at future times.

"alarms",