Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Side by Side Diff: chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc

Issue 2858013002: PS - Showing permission prompt for activeTab (Closed)
Patch Set: Changed permission prompt message Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/extensions/device_local_account_management_pol icy_provider.h" 5 #include "chrome/browser/chromeos/extensions/device_local_account_management_pol icy_provider.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <cstddef> 9 #include <cstddef>
10 #include <string> 10 #include <string>
(...skipping 371 matching lines...) Expand 10 before | Expand all | Expand 10 after
382 // but it seems this does more harm than good as it would likely prevent the 382 // but it seems this does more harm than good as it would likely prevent the
383 // extension from enabling assistive features. If the concerns prevail, we 383 // extension from enabling assistive features. If the concerns prevail, we
384 // should probably not block, but adjust the API to pretend accessibility is 384 // should probably not block, but adjust the API to pretend accessibility is
385 // off, so we don't punish apps that try to be helpful. 385 // off, so we don't punish apps that try to be helpful.
386 "accessibilityFeatures.read", 386 "accessibilityFeatures.read",
387 387
388 // Allows access to web contents in response to user gesture. Note that this 388 // Allows access to web contents in response to user gesture. Note that this
389 // doesn't trigger a permission warning on install though, so blocking is 389 // doesn't trigger a permission warning on install though, so blocking is
390 // somewhat at odds with the spirit of the API - however I presume the API 390 // somewhat at odds with the spirit of the API - however I presume the API
391 // design assumes user-installed extensions, which we don't have here. 391 // design assumes user-installed extensions, which we don't have here.
392 // "activeTab", 392 // Whitelisted because it's restricted now (asks user for permission the
393 // first time an extension tries to use it).
394 "activeTab",
393 395
394 // Schedule code to run at future times. 396 // Schedule code to run at future times.
395 "alarms", 397 "alarms",
396 398
397 // PS UX can always be seen, this one doesn't go over it so it's fine. 399 // PS UX can always be seen, this one doesn't go over it so it's fine.
398 "app.window.alwaysOnTop", 400 "app.window.alwaysOnTop",
399 401
400 // Fullscreen is crippled in Public Sessions, maximizes instead, so both 402 // Fullscreen is crippled in Public Sessions, maximizes instead, so both
401 // fullscreen and overrideEsc are safe for use in PS. (The recommended 403 // fullscreen and overrideEsc are safe for use in PS. (The recommended
402 // permission names are "app.window.*" but their unprefixed counterparts are 404 // permission names are "app.window.*" but their unprefixed counterparts are
(...skipping 542 matching lines...) Expand 10 before | Expand all | Expand 10 after
945 if (error) { 947 if (error) {
946 *error = l10n_util::GetStringFUTF16( 948 *error = l10n_util::GetStringFUTF16(
947 IDS_EXTENSION_CANT_INSTALL_IN_DEVICE_LOCAL_ACCOUNT, 949 IDS_EXTENSION_CANT_INSTALL_IN_DEVICE_LOCAL_ACCOUNT,
948 base::UTF8ToUTF16(extension->name()), 950 base::UTF8ToUTF16(extension->name()),
949 base::UTF8ToUTF16(extension->id())); 951 base::UTF8ToUTF16(extension->id()));
950 } 952 }
951 return false; 953 return false;
952 } 954 }
953 955
954 } // namespace chromeos 956 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698