PS - Showing permission prompt for activeTab

chrome/browser/extensions/extension_install_prompt.cc

Index: chrome/browser/extensions/extension_install_prompt.cc
diff --git a/chrome/browser/extensions/extension_install_prompt.cc b/chrome/browser/extensions/extension_install_prompt.cc
index f09336939a68e49be532c5cb564ebf8ccf507d3f..897208f685a4afc22f0387fcf87a5c0ed55a54ac 100644
--- a/chrome/browser/extensions/extension_install_prompt.cc
+++ b/chrome/browser/extensions/extension_install_prompt.cc
@@ -166,10 +166,6 @@ void ExtensionInstallPrompt::Prompt::SetPermissions(
   InstallPromptPermissions& install_permissions =
       GetPermissionsForType(permissions_type);
 
-  install_permissions.permissions.clear();
-  install_permissions.details.clear();
-  install_permissions.is_showing_details.clear();

[Ivan Šandrk, 2017/05/17 19:10:21]

Didn't really see a reason for them to be cleared here, so I removed this part
since it was clearing the permissions I set on the prompt before calling
ShowDialog(). If that's not acceptable, I'll find another way :)

[Ivan Šandrk, 2017/05/18 12:20:20]

Or I can also do a "renaming" operation, s/SetPermissions/AddPermissions/ :)

(none of the uses of this function relies on the set part, apart from it being
used to add the permissions once)

[Devlin, 2017/05/23 19:28:03]

I think renaming to AddPermissions would make this more clear.

[Ivan Šandrk, 2017/05/24 09:29:01]

Done.

-
   for (const PermissionMessage& msg : permissions) {
     install_permissions.permissions.push_back(msg.message());
     // Add a dash to the front of each permission detail.