PS - Showing permission prompt for activeTab

chrome/browser/extensions/extension_install_prompt.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_install_prompt.h"
 
 #include <utility>
 
 #include "base/callback_helpers.h"
 #include "base/location.h"
@@ skipping 148 matching lines @@
 
 ExtensionInstallPrompt::Prompt::~Prompt() {
 }
 
 void ExtensionInstallPrompt::Prompt::SetPermissions(
     const PermissionMessages& permissions,
     PermissionsType permissions_type) {
   InstallPromptPermissions& install_permissions =
       GetPermissionsForType(permissions_type);
 
-  install_permissions.permissions.clear();
-  install_permissions.details.clear();
-  install_permissions.is_showing_details.clear();

[Ivan Šandrk, 2017/05/17 19:10:21]

Didn't really see a reason for them to be cleared here, so I removed this part
since it was clearing the permissions I set on the prompt before calling
ShowDialog(). If that's not acceptable, I'll find another way :)

[Ivan Šandrk, 2017/05/18 12:20:20]

Or I can also do a "renaming" operation, s/SetPermissions/AddPermissions/ :)

(none of the uses of this function relies on the set part, apart from it being
used to add the permissions once)

[Devlin, 2017/05/23 19:28:03]

I think renaming to AddPermissions would make this more clear.

[Ivan Šandrk, 2017/05/24 09:29:01]

Done.

-
   for (const PermissionMessage& msg : permissions) {
     install_permissions.permissions.push_back(msg.message());
     // Add a dash to the front of each permission detail.
     base::string16 details;
     if (!msg.submessages().empty()) {
       std::vector<base::string16> detail_lines_with_bullets;
       for (const auto& detail_line : msg.submessages()) {
         detail_lines_with_bullets.push_back(base::ASCIIToUTF16("- ") +
                                             detail_line);
       }
@@ skipping 637 matching lines @@
 
   if (AutoConfirmPrompt(&done_callback_))
     return;
 
   if (show_dialog_callback_.is_null())
     show_dialog_callback_ = GetDefaultShowDialogCallback();
   base::ResetAndReturn(&show_dialog_callback_)
       .Run(show_params_.get(), base::ResetAndReturn(&done_callback_),
            std::move(prompt_));
 }