Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: chromeos/dbus/biod/biod_client_unittest.cc

Issue 2858003002: Roll src/third_party/cros_system_api/ c6eab9e4d..6139ae009 + API change (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/dbus/biod/biod_client_unittest.cc
diff --git a/chromeos/dbus/biod/biod_client_unittest.cc b/chromeos/dbus/biod/biod_client_unittest.cc
index 43e141d9047a6e29c1ba3a8e1f2f286911068530..22137ed7702019307795bf7db5ad2a2ceab3fb50 100644
--- a/chromeos/dbus/biod/biod_client_unittest.cc
+++ b/chromeos/dbus/biod/biod_client_unittest.cc
@@ -9,6 +9,8 @@
#include "base/bind.h"
#include "base/run_loop.h"
+#include "base/strings/stringprintf.h"
+#include "chromeos/dbus/biod/messages.pb.h"
#include "chromeos/dbus/biod/test_utils.h"
#include "dbus/mock_bus.h"
#include "dbus/mock_object_proxy.h"
@@ -35,11 +37,6 @@ const char kInvalidTestPath[] = "/invalid/test/path";
// determine when empty values have been assigned.
const char kInvalidString[] = "invalidString";
-// TODO(xiaoyinh@): Use the constant from service_constants.h
-// crbug.com/713420
-const char kBiometricsManagerPath[] =
- "/org/chromium/BiometricsDaemon/FpcBiometricsManager";
-
// Matcher that verifies that a dbus::Message has member |name|.
MATCHER_P(HasMember, name, "") {
if (arg->GetMember() != name) {
@@ -68,9 +65,10 @@ class BiodClientTest : public testing::Test {
options.bus_type = dbus::Bus::SYSTEM;
bus_ = new dbus::MockBus(options);
- proxy_ =
- new dbus::MockObjectProxy(bus_.get(), biod::kBiodServiceName,
- dbus::ObjectPath(kBiometricsManagerPath));
+ dbus::ObjectPath fpc_bio_path = dbus::ObjectPath(base::StringPrintf(
+ "%s/%s", biod::kBiodServicePath, biod::kFpcBiometricsManagerName));
+ proxy_ = new dbus::MockObjectProxy(bus_.get(), biod::kBiodServiceName,
+ fpc_bio_path);
// |client_|'s Init() method should request a proxy for communicating with
// biometrics api.
@@ -119,8 +117,10 @@ class BiodClientTest : public testing::Test {
dbus::Signal signal(kInterface,
biod::kBiometricsManagerEnrollScanDoneSignal);
dbus::MessageWriter writer(&signal);
- writer.AppendUint32(static_cast<uint32_t>(scan_result));
- writer.AppendBool(enroll_session_complete);
+ biod::EnrollScanDone protobuf;
+ protobuf.set_scan_result(scan_result);
+ protobuf.set_done(enroll_session_complete);
+ writer.AppendProtoAsArrayOfBytes(protobuf);
sammiequon 2017/05/03 19:15:57 i think we should update EmitEnrollScanDoneSignal
xiaoyinh(OOO Sep 11-29) 2017/05/04 00:29:51 Updated, thanks! Please let me know if this is goo
sammiequon 2017/05/04 15:55:54 Thanks! It doesn't test much, but at least this fn
EmitSignal(&signal);
}

Powered by Google App Engine
This is Rietveld 408576698