Roll src/third_party/cros_system_api/ c6eab9e4d..6139ae009 + API change

Roll src/third_party/cros_system_api/ c6eab9e4d..6139ae009 + API change

Roll has 1 commit

https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/c6eab9e4d0b4..6139ae00925a

$ git log c6eab9e4d..6139ae009 --date=short --no-merges --format='%ad %ae %s'
2017-04-19 mqg biod: add proto to biod

Created with:
  roll-dep src/third_party/cros_system_api

In addition to roll the cros_system_api, this CL works on the following:
1. Because the change in cros_system_api moved 
biod::ScanResult from cros_system_api/dbus/service_constants.h
to cros_system_api/dbus/biod/constants.proto, we need to update
the files where we use biod::ScanResult

2. The change in cros_system_api added an optional parameter
percent_complete in EnrollScanDone signal and change the dbus message
to a protobuff. Update to dbus/biod and fingerprint_chromeos to incorporate this change.   

A follow-up CL will modify fingerprint settings to use the
percent_complete parameter.

BUG=713420, 718076
Review-Url: https://codereview.chromium.org/2858003002
Cr-Commit-Position: refs/heads/master@{#470102}
Committed: https://chromium.googlesource.com/chromium/src/+/58676cfe8124067c5e2945f235f47ea9e1ec7f6e

[xiaoyinh(OOO Sep 11-29), 2017-05-03 17:04:07]

The CQ bit was checked by xiaoyinh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 17:04:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 18:22:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 18:22:39]

Dry run: This issue passed the CQ dry run.

[xiaoyinh(OOO Sep 11-29), 2017-05-03 18:35:22]

xiaoyinh@chromium.org changed reviewers:
+ blundell@chromium.org, derat@chromium.org, sammiequon@chromium.org,
tsepez@chromium.org

[xiaoyinh(OOO Sep 11-29), 2017-05-03 18:35:23]

Hi, Could you help to take a look? 
+tsepez@ for fingerprint.mojom
+blundell@ for services/device/BUILD.gn
+sammiequon@ for services/device/fingerprint/*
+derat@ for chromeos/dbus
+stevenbj@ for chromeos/dbus, chrome/browser/chromeos/,
chrome/browser/ui/webui/settings

Thank you so much!

[sammiequon, 2017-05-03 19:15:58]

https://codereview.chromium.org/2858003002/diff/1/chromeos/dbus/biod/biod_cli...
File chromeos/dbus/biod/biod_client_unittest.cc (right):

https://codereview.chromium.org/2858003002/diff/1/chromeos/dbus/biod/biod_cli...
chromeos/dbus/biod/biod_client_unittest.cc:123:
writer.AppendProtoAsArrayOfBytes(protobuf);
i think we should update EmitEnrollScanDoneSignal to take in a percent_complete
and test that as well

[Tom Sepez, 2017-05-03 20:21:50]

lgtm

[Daniel Erat, 2017-05-03 20:47:34]

https://codereview.chromium.org/2858003002/diff/1/chromeos/dbus/biod/biod_cli...
File chromeos/dbus/biod/biod_client.cc (right):

https://codereview.chromium.org/2858003002/diff/1/chromeos/dbus/biod/biod_cli...
chromeos/dbus/biod/biod_client.cc:340: 
nit: delete this blank line

https://codereview.chromium.org/2858003002/diff/1/chromeos/dbus/biod/biod_cli...
chromeos/dbus/biod/biod_client.cc:350: protobuf.has_percent_complete() ?
protobuf.percent_complete() : -1;
i can understand caching percent_complete in a local variable, but i'd just
inline the scan_result() and protobuf.done() calls in the observer call unless
there's a good reason not to.

https://codereview.chromium.org/2858003002/diff/1/chromeos/dbus/biod/biod_cli...
File chromeos/dbus/biod/biod_client.h (right):

https://codereview.chromium.org/2858003002/diff/1/chromeos/dbus/biod/biod_cli...
chromeos/dbus/biod/biod_client.h:48: int32_t percent_complete) {}
just use int

https://codereview.chromium.org/2858003002/diff/1/services/device/fingerprint...
File services/device/fingerprint/fingerprint_chromeos_unittest.cc (right):

https://codereview.chromium.org/2858003002/diff/1/services/device/fingerprint...
services/device/fingerprint/fingerprint_chromeos_unittest.cc:77: -1 /*
percent_complete not supported*/);
drop the "not supported" here; we usually just put the parameter name. (also,
there's a space missing before the '*/'). this applies to an earlier file too

https://codereview.chromium.org/2858003002/diff/1/services/device/public/inte...
File services/device/public/interfaces/fingerprint.mojom (right):

https://codereview.chromium.org/2858003002/diff/1/services/device/public/inte...
services/device/public/interfaces/fingerprint.mojom:18: OnEnrollScanDone(uint32
scan_result, bool is_complete, int32 percent_complete);
this looks like it's wrapping. do we usually limit .mojom files to 80 columns?

[xiaoyinh(OOO Sep 11-29), 2017-05-04 00:26:09]

The CQ bit was checked by xiaoyinh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 00:26:54]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xiaoyinh(OOO Sep 11-29), 2017-05-04 00:29:52]

https://codereview.chromium.org/2858003002/diff/1/chromeos/dbus/biod/biod_cli...
File chromeos/dbus/biod/biod_client.cc (right):

https://codereview.chromium.org/2858003002/diff/1/chromeos/dbus/biod/biod_cli...
chromeos/dbus/biod/biod_client.cc:340: 
On 2017/05/03 20:47:34, Daniel Erat wrote:
> nit: delete this blank line

Done.

https://codereview.chromium.org/2858003002/diff/1/chromeos/dbus/biod/biod_cli...
chromeos/dbus/biod/biod_client.cc:350: protobuf.has_percent_complete() ?
protobuf.percent_complete() : -1;
On 2017/05/03 20:47:34, Daniel Erat wrote:
> i can understand caching percent_complete in a local variable, but i'd just
> inline the scan_result() and protobuf.done() calls in the observer call unless
> there's a good reason not to.
Thanks, changed.

https://codereview.chromium.org/2858003002/diff/1/chromeos/dbus/biod/biod_cli...
File chromeos/dbus/biod/biod_client.h (right):

https://codereview.chromium.org/2858003002/diff/1/chromeos/dbus/biod/biod_cli...
chromeos/dbus/biod/biod_client.h:48: int32_t percent_complete) {}
On 2017/05/03 20:47:34, Daniel Erat wrote:
> just use int

Changed here and other places. Except mojom file doesn't seems to accept int as
a type:

Exception: Invalid kind: x:int

https://codereview.chromium.org/2858003002/diff/1/chromeos/dbus/biod/biod_cli...
File chromeos/dbus/biod/biod_client_unittest.cc (right):

https://codereview.chromium.org/2858003002/diff/1/chromeos/dbus/biod/biod_cli...
chromeos/dbus/biod/biod_client_unittest.cc:123:
writer.AppendProtoAsArrayOfBytes(protobuf);
On 2017/05/03 19:15:57, sammiequon wrote:
> i think we should update EmitEnrollScanDoneSignal to take in a
percent_complete
> and test that as well

Updated, thanks! Please let me know if this is good enough.

https://codereview.chromium.org/2858003002/diff/1/services/device/fingerprint...
File services/device/fingerprint/fingerprint_chromeos_unittest.cc (right):

https://codereview.chromium.org/2858003002/diff/1/services/device/fingerprint...
services/device/fingerprint/fingerprint_chromeos_unittest.cc:77: -1 /*
percent_complete not supported*/);
On 2017/05/03 20:47:34, Daniel Erat wrote:
> drop the "not supported" here; we usually just put the parameter name. (also,
> there's a space missing before the '*/'). this applies to an earlier file too

Done.

https://codereview.chromium.org/2858003002/diff/1/services/device/public/inte...
File services/device/public/interfaces/fingerprint.mojom (right):

https://codereview.chromium.org/2858003002/diff/1/services/device/public/inte...
services/device/public/interfaces/fingerprint.mojom:18: OnEnrollScanDone(uint32
scan_result, bool is_complete, int32 percent_complete);
On 2017/05/03 20:47:34, Daniel Erat wrote:
> this looks like it's wrapping. do we usually limit .mojom files to 80 columns?

I checked other mojom files, seems like they are wrapping at 80. I will wrap it
here also.

[xiaoyinh(OOO Sep 11-29), 2017-05-04 00:30:33]

xiaoyinh@chromium.org changed reviewers:
+ stevenjb@chromium.org

[xiaoyinh(OOO Sep 11-29), 2017-05-04 00:30:34]

+stevenjb@ for chromeos/dbus, chrome/browser/chromeos/,
chrome/browser/ui/webui/settings

[commit-bot: I haz the power, 2017-05-04 01:39:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 01:39:56]

Dry run: This issue passed the CQ dry run.

[Daniel Erat, 2017-05-04 03:07:11]

lgtm with a documentation request

https://codereview.chromium.org/2858003002/diff/1/chromeos/dbus/biod/biod_cli...
File chromeos/dbus/biod/biod_client.h (right):

https://codereview.chromium.org/2858003002/diff/1/chromeos/dbus/biod/biod_cli...
chromeos/dbus/biod/biod_client.h:48: int32_t percent_complete) {}
On 2017/05/04 00:29:51, xiaoyinh wrote:
> On 2017/05/03 20:47:34, Daniel Erat wrote:
> > just use int
> 
> Changed here and other places. Except mojom file doesn't seems to accept int
as
> a type:
> 
> Exception: Invalid kind: x:int

yeah, i just meant in c++ code.

https://codereview.chromium.org/2858003002/diff/20001/services/device/public/...
File services/device/public/interfaces/fingerprint.mojom (right):

https://codereview.chromium.org/2858003002/diff/20001/services/device/public/...
services/device/public/interfaces/fingerprint.mojom:17: // and now over.
nit: document percent_complete as well (including mentioning when it's -1)

[blundell, 2017-05-04 15:02:23]

//services/device/BUILD.gn lgtm

[sammiequon, 2017-05-04 15:55:54]

lgtm

https://codereview.chromium.org/2858003002/diff/1/chromeos/dbus/biod/biod_cli...
File chromeos/dbus/biod/biod_client_unittest.cc (right):

https://codereview.chromium.org/2858003002/diff/1/chromeos/dbus/biod/biod_cli...
chromeos/dbus/biod/biod_client_unittest.cc:123:
writer.AppendProtoAsArrayOfBytes(protobuf);
On 2017/05/04 00:29:51, xiaoyinh wrote:
> On 2017/05/03 19:15:57, sammiequon wrote:
> > i think we should update EmitEnrollScanDoneSignal to take in a
> percent_complete
> > and test that as well
> 
> Updated, thanks! Please let me know if this is good enough.

Thanks! It doesn't test much, but at least this fn matches the signal :-P.

[xiaoyinh(OOO Sep 11-29), 2017-05-04 16:55:30]

The CQ bit was checked by xiaoyinh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 16:55:54]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xiaoyinh(OOO Sep 11-29), 2017-05-04 17:07:49]

https://codereview.chromium.org/2858003002/diff/20001/services/device/public/...
File services/device/public/interfaces/fingerprint.mojom (right):

https://codereview.chromium.org/2858003002/diff/20001/services/device/public/...
services/device/public/interfaces/fingerprint.mojom:17: // and now over.
On 2017/05/04 03:07:11, Daniel Erat wrote:
> nit: document percent_complete as well (including mentioning when it's -1)

Done.

[Daniel Erat, 2017-05-04 17:09:35]

thanks, still lgtm

[commit-bot: I haz the power, 2017-05-04 18:25:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 18:25:18]

Dry run: This issue passed the CQ dry run.

[xiaoyinh(OOO Sep 11-29), 2017-05-08 16:40:04]

stevenjb@, could you take a look?

[stevenjb, 2017-05-08 16:56:24]

Can the roll be done separately from the rest of the changes?

Currently the summary does not fully describe the details of this CL.

[xiaoyinh(OOO Sep 11-29), 2017-05-08 17:27:10]

Description was changed from

==========
Roll src/third_party/cros_system_api/ c6eab9e4d..6139ae009 (1 commit)

https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/c6e...

$ git log c6eab9e4d..6139ae009 --date=short --no-merges --format='%ad %ae %s'
2017-04-19 mqg biod: add proto to biod

Created with:
  roll-dep src/third_party/cros_system_api

Biod add an optional parameter percent_complete in EnrollScanDone signal and
change the dbus message to a protobuff.
This CL incorporate this change in chrome.

A follow-up CL will modify fingerprint settings to use the
percent_complete parameter.

BUG=713420, 718076
==========

to

==========
Roll src/third_party/cros_system_api/ c6eab9e4d..6139ae009 (1 commit)

https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/c6e...

$ git log c6eab9e4d..6139ae009 --date=short --no-merges --format='%ad %ae %s'
2017-04-19 mqg biod: add proto to biod

Created with:
  roll-dep src/third_party/cros_system_api

In addition to roll the cros_system_api, this CL works on the following:
1. Because the change in cros_system_api moved 
biod::ScanResult from cros_system_api/dbus/service_constants.h to
cros_system_api/dbus/biod/constants.proto, we need to update the files where we
use biod::ScanResult

2. The change in cros_system_api added an optional parameter percent_complete in
EnrollScanDone signal and change the dbus message to a protobuff. Update to
dbus/biod and fingerprint_chromeos to incorporate this change.   

A follow-up CL will modify fingerprint settings to use the
percent_complete parameter.

BUG=713420, 718076
==========

[xiaoyinh(OOO Sep 11-29), 2017-05-08 17:27:54]

Description was changed from

==========
Roll src/third_party/cros_system_api/ c6eab9e4d..6139ae009 (1 commit)

https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/c6e...

$ git log c6eab9e4d..6139ae009 --date=short --no-merges --format='%ad %ae %s'
2017-04-19 mqg biod: add proto to biod

Created with:
  roll-dep src/third_party/cros_system_api

In addition to roll the cros_system_api, this CL works on the following:
1. Because the change in cros_system_api moved 
biod::ScanResult from cros_system_api/dbus/service_constants.h to
cros_system_api/dbus/biod/constants.proto, we need to update the files where we
use biod::ScanResult

2. The change in cros_system_api added an optional parameter percent_complete in
EnrollScanDone signal and change the dbus message to a protobuff. Update to
dbus/biod and fingerprint_chromeos to incorporate this change.   

A follow-up CL will modify fingerprint settings to use the
percent_complete parameter.

BUG=713420, 718076
==========

to

==========
Roll src/third_party/cros_system_api/ c6eab9e4d..6139ae009 (1 commit)

https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/c6e...

$ git log c6eab9e4d..6139ae009 --date=short --no-merges --format='%ad %ae %s'
2017-04-19 mqg biod: add proto to biod

Created with:
  roll-dep src/third_party/cros_system_api

In addition to roll the cros_system_api, this CL works on the following:
1. Because the change in cros_system_api moved 
biod::ScanResult from cros_system_api/dbus/service_constants.h
to cros_system_api/dbus/biod/constants.proto, we need to update
the files where we use biod::ScanResult

2. The change in cros_system_api added an optional parameter percent_complete in
EnrollScanDone signal and change the dbus
message to a protobuff. Update to dbus/biod and fingerprint_chromeos
to incorporate this change.   

A follow-up CL will modify fingerprint settings to use the
percent_complete parameter.

BUG=713420, 718076
==========

[xiaoyinh(OOO Sep 11-29), 2017-05-08 17:27:54]

Description was changed from

==========
Roll src/third_party/cros_system_api/ c6eab9e4d..6139ae009 (1 commit)

https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/c6e...

$ git log c6eab9e4d..6139ae009 --date=short --no-merges --format='%ad %ae %s'
2017-04-19 mqg biod: add proto to biod

Created with:
  roll-dep src/third_party/cros_system_api

In addition to roll the cros_system_api, this CL works on the following:
1. Because the change in cros_system_api moved 
biod::ScanResult from cros_system_api/dbus/service_constants.h to
cros_system_api/dbus/biod/constants.proto, we need to update the files where we
use biod::ScanResult

2. The change in cros_system_api added an optional parameter percent_complete in
EnrollScanDone signal and change the dbus message to a protobuff. Update to
dbus/biod and fingerprint_chromeos to incorporate this change.   

A follow-up CL will modify fingerprint settings to use the
percent_complete parameter.

BUG=713420, 718076
==========

to

==========
Roll src/third_party/cros_system_api/ c6eab9e4d..6139ae009 (1 commit)

https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/c6e...

$ git log c6eab9e4d..6139ae009 --date=short --no-merges --format='%ad %ae %s'
2017-04-19 mqg biod: add proto to biod

Created with:
  roll-dep src/third_party/cros_system_api

In addition to roll the cros_system_api, this CL works on the following:
1. Because the change in cros_system_api moved 
biod::ScanResult from cros_system_api/dbus/service_constants.h
to cros_system_api/dbus/biod/constants.proto, we need to update
the files where we use biod::ScanResult

2. The change in cros_system_api added an optional parameter percent_complete in
EnrollScanDone signal and change the dbus
message to a protobuff. Update to dbus/biod and fingerprint_chromeos
to incorporate this change.   

A follow-up CL will modify fingerprint settings to use the
percent_complete parameter.

BUG=713420, 718076
==========

[xiaoyinh(OOO Sep 11-29), 2017-05-08 17:29:17]

Description was changed from

==========
Roll src/third_party/cros_system_api/ c6eab9e4d..6139ae009 (1 commit)

https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/c6e...

$ git log c6eab9e4d..6139ae009 --date=short --no-merges --format='%ad %ae %s'
2017-04-19 mqg biod: add proto to biod

Created with:
  roll-dep src/third_party/cros_system_api

In addition to roll the cros_system_api, this CL works on the following:
1. Because the change in cros_system_api moved 
biod::ScanResult from cros_system_api/dbus/service_constants.h
to cros_system_api/dbus/biod/constants.proto, we need to update
the files where we use biod::ScanResult

2. The change in cros_system_api added an optional parameter percent_complete in
EnrollScanDone signal and change the dbus
message to a protobuff. Update to dbus/biod and fingerprint_chromeos
to incorporate this change.   

A follow-up CL will modify fingerprint settings to use the
percent_complete parameter.

BUG=713420, 718076
==========

to

==========
Roll src/third_party/cros_system_api/ c6eab9e4d..6139ae009 (1 commit)

https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/c6e...

$ git log c6eab9e4d..6139ae009 --date=short --no-merges --format='%ad %ae %s'
2017-04-19 mqg biod: add proto to biod

Created with:
  roll-dep src/third_party/cros_system_api

In addition to roll the cros_system_api, this CL works on the following:
1. Because the change in cros_system_api moved 
biod::ScanResult from cros_system_api/dbus/service_constants.h
to cros_system_api/dbus/biod/constants.proto, we need to update
the files where we use biod::ScanResult

2. The change in cros_system_api added an optional parameter
percent_complete in EnrollScanDone signal and change the dbus message
to a protobuff. Update to dbus/biod and fingerprint_chromeos to incorporate this
change.   

A follow-up CL will modify fingerprint settings to use the
percent_complete parameter.

BUG=713420, 718076
==========

[xiaoyinh(OOO Sep 11-29), 2017-05-08 17:32:22]

On 2017/05/08 16:56:24, stevenjb wrote:
> Can the roll be done separately from the rest of the changes?
> 
> Currently the summary does not fully describe the details of this CL.

It needs to be done together because the change in cros_system_api moved 
biod::ScanResult from cros_system_api/dbus/service_constants.h to
cros_system_api/dbus/biod/constants.proto 
and this will break chrome side like screen_locker.cc and biod_client.h where
use biod::ScanResult.

I just updated the description, please let me know if this makes sense.

[stevenjb, 2017-05-08 17:38:48]

Description was changed from

==========
Roll src/third_party/cros_system_api/ c6eab9e4d..6139ae009 (1 commit)

https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/c6e...

$ git log c6eab9e4d..6139ae009 --date=short --no-merges --format='%ad %ae %s'
2017-04-19 mqg biod: add proto to biod

Created with:
  roll-dep src/third_party/cros_system_api

In addition to roll the cros_system_api, this CL works on the following:
1. Because the change in cros_system_api moved 
biod::ScanResult from cros_system_api/dbus/service_constants.h
to cros_system_api/dbus/biod/constants.proto, we need to update
the files where we use biod::ScanResult

2. The change in cros_system_api added an optional parameter
percent_complete in EnrollScanDone signal and change the dbus message
to a protobuff. Update to dbus/biod and fingerprint_chromeos to incorporate this
change.   

A follow-up CL will modify fingerprint settings to use the
percent_complete parameter.

BUG=713420, 718076
==========

to

==========
Roll src/third_party/cros_system_api/ c6eab9e4d..6139ae009 + API change

Roll has 1 commit

https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/c6e...

$ git log c6eab9e4d..6139ae009 --date=short --no-merges --format='%ad %ae %s'
2017-04-19 mqg biod: add proto to biod

Created with:
  roll-dep src/third_party/cros_system_api

In addition to roll the cros_system_api, this CL works on the following:
1. Because the change in cros_system_api moved 
biod::ScanResult from cros_system_api/dbus/service_constants.h
to cros_system_api/dbus/biod/constants.proto, we need to update
the files where we use biod::ScanResult

2. The change in cros_system_api added an optional parameter
percent_complete in EnrollScanDone signal and change the dbus message
to a protobuff. Update to dbus/biod and fingerprint_chromeos to incorporate this
change.   

A follow-up CL will modify fingerprint settings to use the
percent_complete parameter.

BUG=713420, 718076
==========

[stevenjb, 2017-05-08 17:39:06]

I went ahead and modified the Subject as well.

lgtm

[xiaoyinh(OOO Sep 11-29), 2017-05-08 17:41:38]

The CQ bit was checked by xiaoyinh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 17:42:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xiaoyinh(OOO Sep 11-29), 2017-05-08 17:43:57]

On 2017/05/08 17:39:06, stevenjb wrote:
> I went ahead and modified the Subject as well.
> 
> lgtm

Thanks!

[commit-bot: I haz the power, 2017-05-08 19:41:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 19:41:51]

Dry run: This issue passed the CQ dry run.

[xiaoyinh(OOO Sep 11-29), 2017-05-08 20:07:32]

The CQ bit was checked by xiaoyinh@chromium.org

[xiaoyinh(OOO Sep 11-29), 2017-05-08 20:07:33]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
sammiequon@chromium.org, blundell@chromium.org, stevenjb@chromium.org,
derat@chromium.org
Link to the patchset: https://codereview.chromium.org/2858003002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2017-05-08 20:08:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 20:21:45]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1494274052255130,
"parent_rev": "c7b7263536e2151b952fe4f0884bad4e495da2e0", "commit_rev":
"58676cfe8124067c5e2945f235f47ea9e1ec7f6e"}

[commit-bot: I haz the power, 2017-05-08 20:21:53]

Description was changed from

==========
Roll src/third_party/cros_system_api/ c6eab9e4d..6139ae009 + API change

Roll has 1 commit

https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/c6e...

$ git log c6eab9e4d..6139ae009 --date=short --no-merges --format='%ad %ae %s'
2017-04-19 mqg biod: add proto to biod

Created with:
  roll-dep src/third_party/cros_system_api

In addition to roll the cros_system_api, this CL works on the following:
1. Because the change in cros_system_api moved 
biod::ScanResult from cros_system_api/dbus/service_constants.h
to cros_system_api/dbus/biod/constants.proto, we need to update
the files where we use biod::ScanResult

2. The change in cros_system_api added an optional parameter
percent_complete in EnrollScanDone signal and change the dbus message
to a protobuff. Update to dbus/biod and fingerprint_chromeos to incorporate this
change.   

A follow-up CL will modify fingerprint settings to use the
percent_complete parameter.

BUG=713420, 718076
==========

to

==========
Roll src/third_party/cros_system_api/ c6eab9e4d..6139ae009 + API change

Roll has 1 commit

https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/c6e...

$ git log c6eab9e4d..6139ae009 --date=short --no-merges --format='%ad %ae %s'
2017-04-19 mqg biod: add proto to biod

Created with:
  roll-dep src/third_party/cros_system_api

In addition to roll the cros_system_api, this CL works on the following:
1. Because the change in cros_system_api moved 
biod::ScanResult from cros_system_api/dbus/service_constants.h
to cros_system_api/dbus/biod/constants.proto, we need to update
the files where we use biod::ScanResult

2. The change in cros_system_api added an optional parameter
percent_complete in EnrollScanDone signal and change the dbus message
to a protobuff. Update to dbus/biod and fingerprint_chromeos to incorporate this
change.   

A follow-up CL will modify fingerprint settings to use the
percent_complete parameter.

BUG=713420, 718076

Review-Url: https://codereview.chromium.org/2858003002
Cr-Commit-Position: refs/heads/master@{#470102}
Committed:
https://chromium.googlesource.com/chromium/src/+/58676cfe8124067c5e2945f235f4...
==========

[commit-bot: I haz the power, 2017-05-08 20:21:55]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/58676cfe8124067c5e2945f235f4...