Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2857993002: Disable testSignInOpenSettings and testSignInAndTapSettingsLink on iOS. (Closed)

Created:
3 years, 7 months ago by jif
Modified:
3 years, 7 months ago
Reviewers:
bzanotti, jlebel
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable testSignInOpenSettings and testSignInAndTapSettingsLink on iOS. TBR=bzanotti NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=718023 Review-Url: https://codereview.chromium.org/2857993002 Cr-Commit-Position: refs/heads/master@{#468973} Committed: https://chromium.googlesource.com/chromium/src/+/2ce3e34232f0f46251b4a844720f1374433219ee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M ios/chrome/browser/ui/authentication/signin_interaction_controller_egtest.mm View 1 chunk +2 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/first_run/first_run_egtest.mm View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857993002/1
3 years, 7 months ago (2017-05-03 15:05:44 UTC) #4
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 15:06:16 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2ce3e34232f0f46251b4a844720f...

Powered by Google App Engine
This is Rietveld 408576698