Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Unified Diff: chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings.js

Issue 2857983007: Print Preview: Make getChildElement return required HTMLElement (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings.js
diff --git a/chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings.js b/chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings.js
index 194210eec2adb1509225cff891d370d5313152c0..afc4125bb05b6babf3963106a9ddb47fbf143d6a 100644
--- a/chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings.js
+++ b/chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings.js
@@ -70,12 +70,12 @@ cr.define('print_preview', function() {
print_preview.Overlay.prototype.enterDocument.call(this);
this.tracker.add(
- assert(this.getChildElement('.button-strip .cancel-button')),
+ this.getChildElement('.button-strip .cancel-button'),
'click',
this.cancel.bind(this));
this.tracker.add(
- assert(this.getChildElement('.button-strip .done-button')),
+ this.getChildElement('.button-strip .done-button'),
'click',
this.onApplySettings_.bind(this));
@@ -87,7 +87,7 @@ cr.define('print_preview', function() {
/** @override */
decorateInternal: function() {
- this.searchBox_.render(assert(this.getChildElement('.search-box-area')));
+ this.searchBox_.render(this.getChildElement('.search-box-area'));
},
/** @override */
@@ -145,11 +145,10 @@ cr.define('print_preview', function() {
lastVisibleItemWithBubble = item;
});
setIsVisible(
- assert(this.getChildElement('.no-settings-match-hint')),
+ this.getChildElement('.no-settings-match-hint'),
!atLeastOneMatch);
setIsVisible(
- assert(this.getChildElement(
- '.' + AdvancedSettings.Classes_.EXTRA_PADDING)),
+ this.getChildElement('.' + AdvancedSettings.Classes_.EXTRA_PADDING),
!!lastVisibleItemWithBubble);
},
@@ -173,8 +172,8 @@ cr.define('print_preview', function() {
}.bind(this));
this.items_ = [];
- var extraPadding =
- this.getChildElement('.' + AdvancedSettings.Classes_.EXTRA_PADDING);
+ var extraPadding = this.element_.querySelector(
+ '.' + AdvancedSettings.Classes_.EXTRA_PADDING);
if (extraPadding)
extraPadding.parentNode.removeChild(extraPadding);
@@ -191,11 +190,11 @@ cr.define('print_preview', function() {
var item = new print_preview.AdvancedSettingsItem(
this.printTicketStore_, capability);
this.addChild(item);
- item.render(assert(settingsEl));
+ item.render(settingsEl);
this.items_.push(item);
}.bind(this));
- var searchBoxArea = assert(this.getChildElement('.search-box-area'));
+ var searchBoxArea = this.getChildElement('.search-box-area');
if (this.items_.length <= 1) {
setIsVisible(searchBoxArea, false);
} else {

Powered by Google App Engine
This is Rietveld 408576698