Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2857983004: [turbofan] Fix verification of duplicate projections. (Closed)

Created:
3 years, 7 months ago by Jarin
Modified:
3 years, 7 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix verification of duplicate projections. BUG=chromium:712739 Review-Url: https://codereview.chromium.org/2857983004 Cr-Commit-Position: refs/heads/master@{#45081} Committed: https://chromium.googlesource.com/v8/v8/+/102606e8213b43af1b21d1142b1fe790a0212c31

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/compiler/verifier.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Jarin
Could you take a look, please?
3 years, 7 months ago (2017-05-04 10:37:05 UTC) #6
Benedikt Meurer
lgtm
3 years, 7 months ago (2017-05-04 10:38:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857983004/1
3 years, 7 months ago (2017-05-04 10:46:11 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 10:47:53 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/102606e8213b43af1b21d1142b1fe790a02...

Powered by Google App Engine
This is Rietveld 408576698