Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 2857973003: Add a "Show File" button to chrome://net-export/ (Closed)

Created:
3 years, 7 months ago by eroman
Modified:
3 years, 7 months ago
Reviewers:
xunjieli
CC:
chromium-reviews, bnc+watch_chromium.org, mmenke, eroman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a "Show File" button to chrome://net-export/ On desktop platforms, this lets you quickly reveal the log file in the shell after logging has completed. BUG=718062 Review-Url: https://codereview.chromium.org/2857973003 Cr-Commit-Position: refs/heads/master@{#469355} Committed: https://chromium.googlesource.com/chromium/src/+/66fd6b7963a0e9b51d03fc1db5bbc83f6189f38a

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -11 lines) Patch
M chrome/browser/ui/webui/net_export_ui.cc View 6 chunks +25 lines, -0 lines 0 comments Download
M components/net_log/net_export_ui_constants.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/net_log/net_export_ui_constants.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/net_log/resources/net_export.html View 3 chunks +7 lines, -11 lines 1 comment Download
M components/net_log/resources/net_export.js View 3 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
eroman
https://codereview.chromium.org/2857973003/diff/1/components/net_log/resources/net_export.html File components/net_log/resources/net_export.html (left): https://codereview.chromium.org/2857973003/diff/1/components/net_log/resources/net_export.html#oldcode115 components/net_log/resources/net_export.html:115: <div class="warning" id="mobile-private-data-text" hidden> This was unused after my ...
3 years, 7 months ago (2017-05-03 18:35:47 UTC) #2
xunjieli
On 2017/05/03 18:35:47, eroman wrote: > https://codereview.chromium.org/2857973003/diff/1/components/net_log/resources/net_export.html > File components/net_log/resources/net_export.html (left): > > https://codereview.chromium.org/2857973003/diff/1/components/net_log/resources/net_export.html#oldcode115 > ...
3 years, 7 months ago (2017-05-04 15:46:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857973003/1
3 years, 7 months ago (2017-05-04 16:30:52 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 16:37:24 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/66fd6b7963a0e9b51d03fc1db5bb...

Powered by Google App Engine
This is Rietveld 408576698