Flatten Connector & ConnectorImpl

Flatten Connector & ConnectorImpl

R=rockot@chromium.org

Review-Url: https://codereview.chromium.org/2857963004
Cr-Commit-Position: refs/heads/master@{#469271}
Committed: https://chromium.googlesource.com/chromium/src/+/1f1f6b2a18c89d1340d023f2cdb15b2a5c91663e

[Ben Goodger (Google), 2017-05-04 03:27:40]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 03:27:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ben Goodger (Google), 2017-05-04 03:43:54]

Description was changed from

==========
Flatten Connector & ConnectorImpl

BUG=
==========

to

==========
Flatten Connector & ConnectorImpl

R=rockot@chromium.org
==========

[Ben Goodger (Google), 2017-05-04 03:43:54]

ben@chromium.org changed reviewers:
+ rockot@chromium.org

[Ken Rockot(use gerrit already), 2017-05-04 03:53:35]

lgtm

https://codereview.chromium.org/2857963004/diff/20001/services/service_manage...
File services/service_manager/public/cpp/connector.cc (right):

https://codereview.chromium.org/2857963004/diff/20001/services/service_manage...
services/service_manager/public/cpp/connector.cc:13: // Connector, public:
nit: I'd kinda prefer to omit comments like this unless we're going to adopt it
as a universal convention. The file isn't that big

https://codereview.chromium.org/2857963004/diff/20001/services/service_manage...
File services/service_manager/public/cpp/connector_impl.h (right):

https://codereview.chromium.org/2857963004/diff/20001/services/service_manage...
services/service_manager/public/cpp/connector_impl.h:1: // Copyright 2016 The
Chromium Authors. All rights reserved.
Unintentional file copy?

[Ben Goodger (Google), 2017-05-04 04:12:00]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2017-05-04 04:12:00]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2857963004/#ps40001
(title: ".")

[commit-bot: I haz the power, 2017-05-04 04:12:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 05:12:55]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493871120367260,
"parent_rev": "93c0968c8188befdaeaf1d49a98ad9086fa4a0f3", "commit_rev":
"1f1f6b2a18c89d1340d023f2cdb15b2a5c91663e"}

[commit-bot: I haz the power, 2017-05-04 05:13:22]

Description was changed from

==========
Flatten Connector & ConnectorImpl

R=rockot@chromium.org
==========

to

==========
Flatten Connector & ConnectorImpl

R=rockot@chromium.org

Review-Url: https://codereview.chromium.org/2857963004
Cr-Commit-Position: refs/heads/master@{#469271}
Committed:
https://chromium.googlesource.com/chromium/src/+/1f1f6b2a18c89d1340d023f2cdb1...
==========

[commit-bot: I haz the power, 2017-05-04 05:13:23]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1f1f6b2a18c89d1340d023f2cdb1...