Add {Lock,Unlock,Show,Hide}Cursor() to the window manager mojom.

Add apis for the window manager to control the cursor in mus.

This adds {Lock,Unlock,Show,Hide}Cursor() to the window manager mojom,
which all have analogs in the current CursorClient. It also adds the
ability for the window manager to set a global override cursor, which
is used instead of the per-window cursor.

This converts usage of CursorClient to a ShellPort wrapper.

BUG=637853
Review-Url: https://codereview.chromium.org/2857963003
Cr-Commit-Position: refs/heads/master@{#471881}
Committed: https://chromium.googlesource.com/chromium/src/+/1b91d7d3fd76ab7ceb954c05982e6253360c63cf

[Elliot Glaysher, 2017-05-03 21:37:00]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 21:37:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 22:36:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 22:36:08]

Dry run: This issue passed the CQ dry run.

[Elliot Glaysher, 2017-05-04 22:49:03]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 22:49:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 23:54:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 23:54:10]

Dry run: This issue passed the CQ dry run.

[Elliot Glaysher, 2017-05-09 21:54:16]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 21:55:36]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 23:58:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 23:58:15]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has
not started yet; builder either lacks capacity or does not exist (misspelled?))
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet;
builder either lacks capacity or does not exist (misspelled?))
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
build has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
build has not started yet; builder either lacks capacity or does not exist
(misspelled?))

[Elliot Glaysher, 2017-05-10 00:04:03]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 00:06:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 02:09:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 02:09:46]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))

[Elliot Glaysher, 2017-05-10 21:38:46]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 21:39:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 00:41:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 00:41:22]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Elliot Glaysher, 2017-05-11 18:09:08]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 18:10:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Elliot Glaysher, 2017-05-11 18:22:16]

Description was changed from

==========
Add {Lock,Unlock,Show,Hide}Cursor() to the window manager mojom.

Add trusted methods for the window manager to control the appearance of
the cursor.

BUG=637853
==========

to

==========
Add apis for the window manager to control the cursor in mus.

This adds {Lock,Unlock,Show,Hide}Cursor() to the window manager mojom,
which all have analogs in the current CursorClient. It also adds the
ability for the window manager to set a global override cursor, which
is used instead of the per-window cursor.

This converts usage of CursorClient to a ShellPort wrapper.

BUG=637853
==========

[Elliot Glaysher, 2017-05-11 18:22:16]

erg@chromium.org changed reviewers:
+ sky@chromium.org, tsepez@chromium.org

[Elliot Glaysher, 2017-05-11 18:59:54]

tsepez: mojom review. just adds one way communication from window manager to the
mus server.

sky: review

[Tom Sepez, 2017-05-11 19:06:50]

LGTM.

[commit-bot: I haz the power, 2017-05-11 20:20:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 20:20:20]

Dry run: This issue passed the CQ dry run.

[sky, 2017-05-12 13:40:01]

https://codereview.chromium.org/2857963003/diff/80001/ash/utility/screenshot_...
File ash/utility/screenshot_controller.cc (right):

https://codereview.chromium.org/2857963003/diff/80001/ash/utility/screenshot_...
ash/utility/screenshot_controller.cc:214: else
no else afte return.

https://codereview.chromium.org/2857963003/diff/80001/services/ui/ws/display.cc
File services/ui/ws/display.cc (right):

https://codereview.chromium.org/2857963003/diff/80001/services/ui/ws/display....
services/ui/ws/display.cc:250: cursor_lock_count_--;
Having each Display track this state is rather duplicative. WDYT of having a
class that keeps track of the lock count and other state and calls out to each
Display as appropriate? The call out to each display could be done via an
interface to minimize dependencies, but I don't feel strongly about that last
part.

[Elliot Glaysher, 2017-05-12 21:22:18]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-12 21:23:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Elliot Glaysher, 2017-05-12 22:56:35]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-12 22:57:43]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Elliot Glaysher, 2017-05-12 23:02:44]

https://codereview.chromium.org/2857963003/diff/80001/ash/utility/screenshot_...
File ash/utility/screenshot_controller.cc (right):

https://codereview.chromium.org/2857963003/diff/80001/ash/utility/screenshot_...
ash/utility/screenshot_controller.cc:214: else
On 2017/05/12 13:40:01, sky wrote:
> no else afte return.

replaced with braces and a comment

https://codereview.chromium.org/2857963003/diff/80001/services/ui/ws/display.cc
File services/ui/ws/display.cc (right):

https://codereview.chromium.org/2857963003/diff/80001/services/ui/ws/display....
services/ui/ws/display.cc:250: cursor_lock_count_--;
On 2017/05/12 13:40:01, sky wrote:
> Having each Display track this state is rather duplicative. WDYT of having a
> class that keeps track of the lock count and other state and calls out to each
> Display as appropriate? The call out to each display could be done via an
> interface to minimize dependencies, but I don't feel strongly about that last
> part.

Created CursorState class, which is owned by window_manager_state() and takes a
DisplayManager* in its ctor.

[commit-bot: I haz the power, 2017-05-13 01:59:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-13 01:59:27]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[sky, 2017-05-14 16:12:31]

LGTM

https://codereview.chromium.org/2857963003/diff/120001/services/ui/ws/cursor_...
File services/ui/ws/cursor_state.h (right):

https://codereview.chromium.org/2857963003/diff/120001/services/ui/ws/cursor_...
services/ui/ws/cursor_state.h:21: CursorState(DisplayManager* display_manager);
explicit

https://codereview.chromium.org/2857963003/diff/120001/services/ui/ws/cursor_...
services/ui/ws/cursor_state.h:51: int cursor_lock_count_ = 0u;
You shouldn't need the 'u' here.

https://codereview.chromium.org/2857963003/diff/120001/services/ui/ws/cursor_...
File services/ui/ws/cursor_state_unittest.cc (right):

https://codereview.chromium.org/2857963003/diff/120001/services/ui/ws/cursor_...
services/ui/ws/cursor_state_unittest.cc:5: #include
"services/ui/ws/cursor_state.h"
newline between 5/6.

[Elliot Glaysher, 2017-05-15 18:12:25]

The CQ bit was checked by erg@chromium.org

[Elliot Glaysher, 2017-05-15 18:12:25]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2857963003/#ps140001
(title: "sky comments")

[commit-bot: I haz the power, 2017-05-15 18:13:11]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 20:17:09]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1494871945136390,
"parent_rev": "b7f0280c151feb4213f2a736276849a5b419c8ea", "commit_rev":
"1b91d7d3fd76ab7ceb954c05982e6253360c63cf"}

[commit-bot: I haz the power, 2017-05-15 20:17:20]

Description was changed from

==========
Add apis for the window manager to control the cursor in mus.

This adds {Lock,Unlock,Show,Hide}Cursor() to the window manager mojom,
which all have analogs in the current CursorClient. It also adds the
ability for the window manager to set a global override cursor, which
is used instead of the per-window cursor.

This converts usage of CursorClient to a ShellPort wrapper.

BUG=637853
==========

to

==========
Add apis for the window manager to control the cursor in mus.

This adds {Lock,Unlock,Show,Hide}Cursor() to the window manager mojom,
which all have analogs in the current CursorClient. It also adds the
ability for the window manager to set a global override cursor, which
is used instead of the per-window cursor.

This converts usage of CursorClient to a ShellPort wrapper.

BUG=637853

Review-Url: https://codereview.chromium.org/2857963003
Cr-Commit-Position: refs/heads/master@{#471881}
Committed:
https://chromium.googlesource.com/chromium/src/+/1b91d7d3fd76ab7ceb954c05982e...
==========

[commit-bot: I haz the power, 2017-05-15 20:17:23]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/1b91d7d3fd76ab7ceb954c05982e...