Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2857913002: [DeviceService] Revise PowerMonitorMessageBroadcasterTest to be a service test (Closed)

Created:
3 years, 7 months ago by leonhsl(Using Gerrit)
Modified:
3 years, 7 months ago
Reviewers:
blundell
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DeviceService] Revise PowerMonitorMessageBroadcasterTest to be a service test Currently PowerMonitorMessageBroadcasterTest is just an unit test for PowerMonitorMessageBroadcaster class, this CL revises it to be a service test: - Keep all the existing test cases verifying internal impl logic of PowerMonitorMessageBroadcaster. - In addition, verify that PowerMonitorBroadcastSource(in power monitor client library) can interact correctly with the PowerMonitorMessageBroadcaster instantiated inside a real Device Service instance. BUG=715985 TEST=service_unittests Review-Url: https://codereview.chromium.org/2857913002 Cr-Commit-Position: refs/heads/master@{#468929} Committed: https://chromium.googlesource.com/chromium/src/+/6561c2f12d7c6d68613da7500643b300b923e15b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -26 lines) Patch
M services/device/power_monitor/power_monitor_message_broadcaster_unittest.cc View 3 chunks +28 lines, -26 lines 0 comments Download
M services/device/unittest_manifest.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
leonhsl(Using Gerrit)
PTAL, Thanks.
3 years, 7 months ago (2017-05-03 08:24:00 UTC) #5
blundell
Great! lgtm
3 years, 7 months ago (2017-05-03 09:25:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857913002/1
3 years, 7 months ago (2017-05-03 09:50:59 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 09:56:31 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6561c2f12d7c6d68613da7500643...

Powered by Google App Engine
This is Rietveld 408576698