Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2857893003: Replace search_sogou.png with a vector drawable (Closed)

Created:
3 years, 7 months ago by Theresa
Modified:
3 years, 7 months ago
Reviewers:
gone
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace search_sogou.png with a vector drawable Extends PromoDialog to support vector drawables, and replaces the large search_sogou.png asset with a vector drawable. Replaces 131,070 bytes with 4,834. BUG=666062 Review-Url: https://codereview.chromium.org/2857893003 Cr-Commit-Position: refs/heads/master@{#469381} Committed: https://chromium.googlesource.com/chromium/src/+/4ca7aa467fe923df274c52832ed4a389c8159b9a

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix tests #

Messages

Total messages: 19 (12 generated)
Theresa
ptal, screenshots in the bug
3 years, 7 months ago (2017-05-03 21:00:00 UTC) #4
Theresa
https://codereview.chromium.org/2857893003/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/widget/PromoDialogTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/widget/PromoDialogTest.java (right): https://codereview.chromium.org/2857893003/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/widget/PromoDialogTest.java#newcode105 chrome/android/javatests/src/org/chromium/chrome/browser/widget/PromoDialogTest.java:105: dialogParams.drawableResource = R.drawable.search_sogou; I need to update this usage ...
3 years, 7 months ago (2017-05-03 23:09:50 UTC) #7
Theresa
https://codereview.chromium.org/2857893003/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/widget/PromoDialogTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/widget/PromoDialogTest.java (right): https://codereview.chromium.org/2857893003/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/widget/PromoDialogTest.java#newcode105 chrome/android/javatests/src/org/chromium/chrome/browser/widget/PromoDialogTest.java:105: dialogParams.drawableResource = R.drawable.search_sogou; On 2017/05/03 23:09:50, Theresa wrote: > ...
3 years, 7 months ago (2017-05-04 16:53:17 UTC) #12
gone
lgtm
3 years, 7 months ago (2017-05-04 17:08:27 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857893003/20001
3 years, 7 months ago (2017-05-04 17:53:47 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/4ca7aa467fe923df274c52832ed4a389c8159b9a
3 years, 7 months ago (2017-05-04 18:15:09 UTC) #18
estevenson
3 years, 7 months ago (2017-05-05 22:29:09 UTC) #19
Message was sent while issue was closed.
On 2017/05/04 18:15:09, commit-bot: I haz the power wrote:
> Committed patchset #2 (id:20001) as
>
https://chromium.googlesource.com/chromium/src/+/4ca7aa467fe923df274c52832ed4...

Nice!!
https://chromeperf.appspot.com/report?sid=5d55db44beb13bb1e813882381fe82b47aa...

Powered by Google App Engine
This is Rietveld 408576698