Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2857873003: Move StyleBoxData.cpp to be inline in StyleBoxData.h. (Closed)

Created:
3 years, 7 months ago by shend
Modified:
3 years, 7 months ago
Reviewers:
meade_UTC10
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move StyleBoxData.cpp to be inline in StyleBoxData.h. This patch removes StyleBoxData.cpp, and moves all its contents to be inline in StyleBoxData.h This is prework for generating StyleBoxData. BUG=628043 Review-Url: https://codereview.chromium.org/2857873003 Cr-Commit-Position: refs/heads/master@{#470868} Committed: https://chromium.googlesource.com/chromium/src/+/fc17a86b6a7a678a7125b0caa7c0aa1c1bee6713

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -61 lines) Patch
M third_party/WebKit/Source/core/style/BUILD.gn View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/StyleBoxData.h View 1 chunk +24 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/core/style/StyleBoxData.cpp View 1 chunk +0 lines, -58 lines 0 comments Download

Messages

Total messages: 47 (31 generated)
shend
Hi Eddy, PTAL
3 years, 7 months ago (2017-05-03 22:59:24 UTC) #6
meade_UTC10
lgtm
3 years, 7 months ago (2017-05-04 04:52:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857873003/1
3 years, 7 months ago (2017-05-08 22:22:47 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cronet/builds/134602) cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, ...
3 years, 7 months ago (2017-05-08 22:46:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857873003/20001
3 years, 7 months ago (2017-05-08 22:57:40 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/406172) win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, ...
3 years, 7 months ago (2017-05-09 00:43:24 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857873003/20001
3 years, 7 months ago (2017-05-09 04:01:36 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/439146)
3 years, 7 months ago (2017-05-09 08:15:23 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857873003/20001
3 years, 7 months ago (2017-05-09 22:14:59 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; ...
3 years, 7 months ago (2017-05-10 00:18:33 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857873003/20001
3 years, 7 months ago (2017-05-10 05:49:03 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/449707)
3 years, 7 months ago (2017-05-10 09:27:30 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857873003/20001
3 years, 7 months ago (2017-05-10 12:58:20 UTC) #31
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/449979)
3 years, 7 months ago (2017-05-10 15:36:14 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857873003/40001
3 years, 7 months ago (2017-05-11 07:36:06 UTC) #44
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 08:04:10 UTC) #47
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/fc17a86b6a7a678a7125b0caa7c0...

Powered by Google App Engine
This is Rietveld 408576698