Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2857833003: Print warning if IIR filter is unstable (Closed)

Created:
3 years, 7 months ago by Raymond Toy
Modified:
3 years, 7 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews, haraken, hongchan
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Print warning if IIR filter is unstable If the specified IIR filter is unstable, print a warning message to the console. However, the IIR filter is still created successfully. BUG=717556 TEST=IIRFilter/iir-unstable.html Review-Url: https://codereview.chromium.org/2857833003 Cr-Commit-Position: refs/heads/master@{#471823} Committed: https://chromium.googlesource.com/chromium/src/+/d0602af69e19b44bbbbc64165766098d9c9e36a6

Patch Set 1 #

Patch Set 2 : Clean up StringBuilder usage. #

Patch Set 3 : Normalize only if needed. #

Patch Set 4 : Use stable IIR filter for test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-nominal-range.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/webaudio/IIRFilter/iir-unstable.html View 1 chunk +27 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/webaudio/IIRFilter/iir-unstable-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/IIRFilterNode.cpp View 1 2 3 chunks +60 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
Raymond Toy
PTAL
3 years, 7 months ago (2017-05-08 21:42:18 UTC) #3
hongchan
Why are trybots red/purple?
3 years, 7 months ago (2017-05-10 15:21:19 UTC) #4
Raymond Toy
On 2017/05/10 15:21:19, hongchan wrote: > Why are trybots red/purple? The red bot has an ...
3 years, 7 months ago (2017-05-10 16:25:42 UTC) #5
hongchan
lgtm, but please take a look at why a bot is red.
3 years, 7 months ago (2017-05-12 16:30:25 UTC) #6
Raymond Toy
On 2017/05/12 16:30:25, hongchan wrote: > lgtm, but please take a look at why a ...
3 years, 7 months ago (2017-05-12 16:32:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857833003/60001
3 years, 7 months ago (2017-05-12 16:34:28 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/443141)
3 years, 7 months ago (2017-05-12 18:45:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857833003/60001
3 years, 7 months ago (2017-05-12 19:45:38 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/292847)
3 years, 7 months ago (2017-05-12 19:49:58 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857833003/60001
3 years, 7 months ago (2017-05-15 16:01:23 UTC) #17
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 17:55:40 UTC) #20
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/d0602af69e19b44bbbbc64165766...

Powered by Google App Engine
This is Rietveld 408576698