Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 2857803002: Shape Detection: reconnect LayoutTests (Closed)

Created:
3 years, 7 months ago by mcasas
Modified:
3 years, 7 months ago
CC:
chromium-reviews, blink-reviews, junwei
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Sort out test names so they are not repeated #

Patch Set 3 : Removed expectation files and corrected shapedetection-empty-input test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -148 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 3 chunks +0 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input.html View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input-expected.txt View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/shapedetection/shapedetection-cross-origin.html View 1 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/http/tests/shapedetection/shapedetection-cross-origin-expected.txt View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/shapedetection/detection-HTMLCanvasElement-expected.txt View 1 2 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/shapedetection/detection-HTMLImageElement-expected.txt View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/shapedetection/detection-HTMLVideoElement-expected.txt View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/shapedetection/detection-ImageBitmap-expected.txt View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/shapedetection/detection-ImageData-expected.txt View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/shapedetection/detection-security-test-expected.txt View 1 2 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/virtual/mojo-loading/http/tests/shapedetection/shapedetection-cross-origin-expected.txt View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html View 1 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html View 1 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html View 1 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html View 1 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html View 1 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/shapedetection/detection-security-test.html View 1 2 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
mcasas
reillyg@ tiny CL PTAL
3 years, 7 months ago (2017-05-02 22:08:40 UTC) #4
Reilly Grant (use Gerrit)
It looks like they ain't so good.
3 years, 7 months ago (2017-05-02 23:29:10 UTC) #5
mcasas
On 2017/05/02 23:29:10, Reilly Grant wrote: > It looks like they ain't so good. run_webkit_tests ...
3 years, 7 months ago (2017-05-02 23:50:13 UTC) #6
Reilly Grant (use Gerrit)
lgtm If it passes then it's good.
3 years, 7 months ago (2017-05-03 00:09:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857803002/40001
3 years, 7 months ago (2017-05-03 14:48:49 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 14:53:45 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7f6b49242db9774de7370bd302ff...

Powered by Google App Engine
This is Rietveld 408576698