Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 2857763002: [Media Router] Fix unit test "DeviceDescriptionServiceTest.TestCleanUpCacheEntries" (Closed)

Created:
3 years, 7 months ago by zhaobin
Modified:
3 years, 7 months ago
Reviewers:
mark a. foltz, imcheng
CC:
chromium-reviews, feature-media-reviews_chromium.org, media-router+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router] Fix unit test "DeviceDescriptionServiceTest.TestCleanUpCacheEntries" cache_entry.expire_time = base::Time::Now(); does not guarantee the cache entry is expired. BUG=716810 Review-Url: https://codereview.chromium.org/2857763002 Cr-Commit-Position: refs/heads/master@{#468846} Committed: https://chromium.googlesource.com/chromium/src/+/b68a2976a94249c55ad3b0bacee12bf047cacfc9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M chrome/browser/media/router/discovery/dial/device_description_service_unittest.cc View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
zhaobin
3 years, 7 months ago (2017-05-02 20:58:40 UTC) #2
mark a. foltz
LGTM Thanks for the quick fix. This might be a place to inject a mock ...
3 years, 7 months ago (2017-05-02 21:05:50 UTC) #3
imcheng
lgtm
3 years, 7 months ago (2017-05-03 00:07:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857763002/1
3 years, 7 months ago (2017-05-03 00:47:07 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 00:54:11 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b68a2976a94249c55ad3b0bacee1...

Powered by Google App Engine
This is Rietveld 408576698