Re-enable 3 DumpAccessibilityEvents tests that were disabled on windows.

Re-enable 3 DumpAccessibilityEvents tests that were disabled on windows.

They all had the same underlying cause: we were firing accessibility events
based on changes to the accessibility tree, but before we had finished
making changes to BrowserAccessibilityWin. To fix this, queue up events
caused by tree changes and fire them after the tree is loaded.

We should probably use this technique more in the future. For now this
just re-enables some good tests.

BUG=719030
Review-Url: https://codereview.chromium.org/2857743006
Cr-Commit-Position: refs/heads/master@{#471140}
Committed: https://chromium.googlesource.com/chromium/src/+/19776ea6b20f56507e080f09a8b508c3ec6ba5be

[dmazzoni, 2017-05-05 22:31:00]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[dmazzoni, 2017-05-05 22:31:20]

dmazzoni@chromium.org changed reviewers:
+ nektar@chromium.org

[commit-bot: I haz the power, 2017-05-05 22:33:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 23:40:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 23:40:17]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dmazzoni, 2017-05-10 16:19:34]

Nektarios, could you review this one now?

[nektarios, 2017-05-10 16:32:31]

+  // Now iterate over the event from the renderer and fire the events
events, not event.

[chromium-reviews, 2017-05-10 16:33:29]

Re: combo box tests on Mac. I thought that Elly had looked into those 
last year?

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[nektarios, 2017-05-10 16:35:02]

lgtm

[dmazzoni, 2017-05-11 21:57:18]

On 2017/05/10 16:32:31, nektarios wrote:
> +  // Now iterate over the event from the renderer and fire the events
> events, not event.

Done

[dmazzoni, 2017-05-11 21:57:59]

On 2017/05/10 16:33:29, chromium-reviews wrote:
> Re: combo box tests on Mac. I thought that Elly had looked into those 
> last year?

I will try to re-enable more tests. I just want to do a few at a time
in case new flakiness emerges.

[dmazzoni, 2017-05-11 22:29:06]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2017-05-11 22:29:06]

The patchset sent to the CQ was uploaded after l-g-t-m from nektar@chromium.org
Link to the patchset: https://codereview.chromium.org/2857743006/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2017-05-11 22:30:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 00:22:43]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494541746066450,
"parent_rev": "03772bfdc7bc49e6d4486ea98a41738e89ded9b5", "commit_rev":
"19776ea6b20f56507e080f09a8b508c3ec6ba5be"}

[commit-bot: I haz the power, 2017-05-12 00:22:55]

Description was changed from

==========
Re-enable 3 DumpAccessibilityEvents tests that were disabled on windows.

They all had the same underlying cause: we were firing accessibility events
based on changes to the accessibility tree, but before we had finished
making changes to BrowserAccessibilityWin. To fix this, queue up events
caused by tree changes and fire them after the tree is loaded.

We should probably use this technique more in the future. For now this
just re-enables some good tests.

BUG=719030
==========

to

==========
Re-enable 3 DumpAccessibilityEvents tests that were disabled on windows.

They all had the same underlying cause: we were firing accessibility events
based on changes to the accessibility tree, but before we had finished
making changes to BrowserAccessibilityWin. To fix this, queue up events
caused by tree changes and fire them after the tree is loaded.

We should probably use this technique more in the future. For now this
just re-enables some good tests.

BUG=719030

Review-Url: https://codereview.chromium.org/2857743006
Cr-Commit-Position: refs/heads/master@{#471140}
Committed:
https://chromium.googlesource.com/chromium/src/+/19776ea6b20f56507e080f09a8b5...
==========

[commit-bot: I haz the power, 2017-05-12 00:22:56]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/19776ea6b20f56507e080f09a8b5...