Issue 2857743005: Partial revert of r469453.

Issue 2857743005: Partial revert of r469453. (Closed)

Created:
3 years, 7 months ago by Lei Zhang

Modified:
3 years, 7 months ago

Reviewers:
dsinclair

CC:
chromium-reviews

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

Partial revert of r469453. Depending on chrome/common/url_constants.h makes it harder for other targets to use the code in pdf/. TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2857743005 Cr-Commit-Position: refs/heads/master@{#469602} Committed: https://chromium.googlesource.com/chromium/src/+/3dcbe10ffd2973312634835414fa0a31f52068a6

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -5 lines)			Patch
	M	pdf/DEPS	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	pdf/out_of_process_instance.cc	View		4 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 8 (4 generated)

Lei Zhang

https://codereview.chromium.org/2829973002/ is trying to use pdf/ in their tests to read the generated PDF.

3 years, 7 months ago (2017-05-05 04:19:42 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857743005/1

3 years, 7 months ago (2017-05-05 04:20:57 UTC) #5

commit-bot: I haz the power

3 years, 7 months ago (2017-05-05 05:37:21 UTC) #8

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3dcbe10ffd2973312634835414fa...