Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 2857743004: Workaround for UCRT deadlock between gpu's main and watchdog threads (Closed)

Created:
3 years, 7 months ago by mmarkowicz
Modified:
3 years, 7 months ago
CC:
chromium-reviews, piman+watch_chromium.org, piman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Workaround for UCRT deadlock between gpu's main and watchdog threads Deadlock is likely caused by UCRT lib bug that can be reproduced with low-frequency in Opera Browser on Windows 7. Deadlock will permanently freeze gpu process (watchdog will not intervene as, ironically, it's involved in a deadlock). BUG=718388 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2857743004 Cr-Commit-Position: refs/heads/master@{#469617} Committed: https://chromium.googlesource.com/chromium/src/+/abecaf4066bdffab7af3e26102d2e2644835d8a9

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M gpu/ipc/service/gpu_init.cc View 1 chunk +15 lines, -1 line 1 comment Download

Messages

Total messages: 14 (8 generated)
mmarkowicz
We couldn't reproduce this freeze in Chrome, but in Opera it isn't easy to reproduce ...
3 years, 7 months ago (2017-05-04 11:35:53 UTC) #4
Ken Russell (switch to Gerrit)
Thanks for measuring the startup time impact. The 0.1 ms delay sounds acceptable to me, ...
3 years, 7 months ago (2017-05-04 17:18:48 UTC) #6
jbauman
lgtm. Do you know what's calling setlocale? Something in the driver?
3 years, 7 months ago (2017-05-04 18:15:52 UTC) #7
mmarkowicz
On 2017/05/04 18:15:52, jbauman wrote: > lgtm. Do you know what's calling setlocale? Something in ...
3 years, 7 months ago (2017-05-05 09:14:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857743004/1
3 years, 7 months ago (2017-05-05 09:15:33 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 10:19:10 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/abecaf4066bdffab7af3e26102d2...

Powered by Google App Engine
This is Rietveld 408576698