Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2857663003: Add @TargetApi annotation to ChromeUsbInterface.getAlternateSetting (Closed)

Created:
3 years, 7 months ago by Reilly Grant (use Gerrit)
Modified:
3 years, 7 months ago
Reviewers:
scheib
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add @TargetApi annotation to ChromeUsbInterface.getAlternateSetting This annotation was missing. The native side only calls this method if the API version is greater than or equal to 21 (Lolipop). BUG=635567 Review-Url: https://codereview.chromium.org/2857663003 Cr-Commit-Position: refs/heads/master@{#468869} Committed: https://chromium.googlesource.com/chromium/src/+/f8bfab30bb6ee9f95277a16ee02bc930da2b2a2a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M device/usb/android/java/src/org/chromium/device/usb/ChromeUsbInterface.java View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Reilly Grant (use Gerrit)
PTAL (trivial)
3 years, 7 months ago (2017-05-03 01:06:12 UTC) #3
scheib
lgtm
3 years, 7 months ago (2017-05-03 01:20:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857663003/1
3 years, 7 months ago (2017-05-03 01:29:43 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 01:58:58 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f8bfab30bb6ee9f95277a16ee02b...

Powered by Google App Engine
This is Rietveld 408576698