Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1313)

Unified Diff: third_party/WebKit/Source/core/workers/MainThreadWorkletTest.cpp

Issue 2857583003: Worker: Avoid sending IPC messages for features already counted (Closed)
Patch Set: wip Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/workers/MainThreadWorkletTest.cpp
diff --git a/third_party/WebKit/Source/core/workers/MainThreadWorkletTest.cpp b/third_party/WebKit/Source/core/workers/MainThreadWorkletTest.cpp
index 5fedf9f69018c6fc40d02ee71bfb0f59f89cfeac..ba8f1518a785c7730ab41af1e4b4eebddbb79724 100644
--- a/third_party/WebKit/Source/core/workers/MainThreadWorkletTest.cpp
+++ b/third_party/WebKit/Source/core/workers/MainThreadWorkletTest.cpp
@@ -11,6 +11,39 @@
namespace blink {
+class MainThreadWorkletGlobalScopeForTest
+ : public MainThreadWorkletGlobalScope {
+ public:
+ MainThreadWorkletGlobalScopeForTest(LocalFrame* frame,
+ const KURL& url,
+ const String& user_agent,
+ RefPtr<SecurityOrigin> security_origin,
+ v8::Isolate* isolate)
+ : MainThreadWorkletGlobalScope(frame,
+ url,
+ user_agent,
+ std::move(security_origin),
+ isolate),
+ reported_features_(UseCounter::kNumberOfFeatures) {}
+
+ void ReportFeature(UseCounter::Feature feature) override {
+ // Any feature should be reported only one time.
+ EXPECT_FALSE(reported_features_.QuickGet(feature));
+ reported_features_.QuickSet(feature);
+ MainThreadWorkletGlobalScope::ReportFeature(feature);
+ }
+
+ void ReportDeprecation(UseCounter::Feature feature) final {
+ // Any feature should be reported only one time.
+ EXPECT_FALSE(reported_features_.QuickGet(feature));
+ reported_features_.QuickSet(feature);
+ MainThreadWorkletGlobalScope::ReportDeprecation(feature);
+ }
+
+ private:
+ BitVector reported_features_;
+};
+
class MainThreadWorkletTest : public ::testing::Test {
public:
void SetUp() override {
@@ -42,6 +75,10 @@ TEST_F(MainThreadWorkletTest, UseCounter) {
UseCounter::Count(global_scope_, kFeature1);
EXPECT_TRUE(UseCounter::IsCounted(document, kFeature1));
+ // API use should be reported to the Document only one time. See comments in
+ // MainThreadGlobalScopeForTest::ReportFeature.
+ UseCounter::Count(global_scope_, kFeature1);
+
// This feature is randomly selected from Deprecation::deprecationMessage().
const UseCounter::Feature kFeature2 =
UseCounter::Feature::kPrefixedStorageInfo;
@@ -51,6 +88,10 @@ TEST_F(MainThreadWorkletTest, UseCounter) {
EXPECT_FALSE(UseCounter::IsCounted(document, kFeature2));
Deprecation::CountDeprecation(global_scope_, kFeature2);
EXPECT_TRUE(UseCounter::IsCounted(document, kFeature2));
+
+ // API use should be reported to the Document only one time. See comments in
+ // MainThreadWorkletGlobalScopeForTest::ReportDeprecation.
+ Deprecation::CountDeprecation(global_scope_, kFeature2);
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698