Worker: Avoid sending IPC messages for features already counted

Worker: Avoid sending IPC messages for features already counted

When a feature listed on UseCounter::Feature is used on
Shared/ServiceWorkerGlobalScope, it's reported to connecting/controlling
documents via the browser process and counted in their UseCounters.

These IPC messages should be sent only one time per feature, but unfortunately
"worker->browser" IPC is sent every time a feature is used. This is not
efficient.

This CL memorizes feature use in worker-side and avoids sending duplicate IPC
messages to the browser process.

<Example of the calling sequence>

(Some feature is used on ServiceWorkerGlobalScope)
UseCounter::CountFeature
- WorkerOrWorkletGlobalScope::CountFeature
  (memorizes feature use and returns early if it's already reported)
  - WorkerGlobalScope::ReportFeature
    - ServiceWorkerGlobalScopeProxy::CountFeature
      - ServiceWorkerContextClient (sends an IPC message to the browser)

BUG=714551
Review-Url: https://codereview.chromium.org/2857583003
Cr-Commit-Position: refs/heads/master@{#469965}
Committed: https://chromium.googlesource.com/chromium/src/+/c7acabe9f43065280edf2dee91ae53f6472dcf02

[nhiroki, 2017-05-08 08:12:32]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 08:13:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2017-05-08 09:30:55]

Description was changed from

==========
Worker: Avoid sending IPC messages for already counted features

TODO
- Write tests

BUG=714551
==========

to

==========
Worker: Avoid sending IPC messages for features already counted

When some feature listed on UseCounter::Feature is used on
Shared/ServiceWorkerGlobalScope, it's reported to connecting/controlling
documents via the browser process and counted in their UseCounters.

This IPC message should be sent only one time per feature, but unfortunately
"worker->browser" IPC is sent every time a feature is used. This is not
efficient.

This CL memorizes features already counted in worker's renderer process and
avoids sending duplicated IPC messages to the browser process.

BUG=714551
==========

[nhiroki, 2017-05-08 09:31:37]

Description was changed from

==========
Worker: Avoid sending IPC messages for features already counted

When some feature listed on UseCounter::Feature is used on
Shared/ServiceWorkerGlobalScope, it's reported to connecting/controlling
documents via the browser process and counted in their UseCounters.

This IPC message should be sent only one time per feature, but unfortunately
"worker->browser" IPC is sent every time a feature is used. This is not
efficient.

This CL memorizes features already counted in worker's renderer process and
avoids sending duplicated IPC messages to the browser process.

BUG=714551
==========

to

==========
Worker: Avoid sending IPC messages for features already counted

When some feature listed on UseCounter::Feature is used on
Shared/ServiceWorkerGlobalScope, it's reported to connecting/controlling
documents via the browser process and counted in their UseCounters.

This IPC messages should be sent only one time per feature, but unfortunately
"worker->browser" IPC is sent every time a feature is used. This is not
efficient.

This CL memorizes features already counted in worker's renderer process and
avoids sending duplicated IPC messages to the browser process.

BUG=714551
==========

[nhiroki, 2017-05-08 09:34:07]

Description was changed from

==========
Worker: Avoid sending IPC messages for features already counted

When some feature listed on UseCounter::Feature is used on
Shared/ServiceWorkerGlobalScope, it's reported to connecting/controlling
documents via the browser process and counted in their UseCounters.

This IPC messages should be sent only one time per feature, but unfortunately
"worker->browser" IPC is sent every time a feature is used. This is not
efficient.

This CL memorizes features already counted in worker's renderer process and
avoids sending duplicated IPC messages to the browser process.

BUG=714551
==========

to

==========
Worker: Avoid sending IPC messages for features already counted

When a feature listed on UseCounter::Feature is used on
Shared/ServiceWorkerGlobalScope, it's reported to connecting/controlling
documents via the browser process and counted in their UseCounters.

These IPC messages should be sent only one time per feature, but unfortunately
"worker->browser" IPC is sent every time a feature is used. This is not
efficient.

This CL memorizes features already counted in worker-side and avoids sending
duplicate IPC messages to the browser process.

BUG=714551
==========

[nhiroki, 2017-05-08 09:42:22]

Description was changed from

==========
Worker: Avoid sending IPC messages for features already counted

When a feature listed on UseCounter::Feature is used on
Shared/ServiceWorkerGlobalScope, it's reported to connecting/controlling
documents via the browser process and counted in their UseCounters.

These IPC messages should be sent only one time per feature, but unfortunately
"worker->browser" IPC is sent every time a feature is used. This is not
efficient.

This CL memorizes features already counted in worker-side and avoids sending
duplicate IPC messages to the browser process.

BUG=714551
==========

to

==========
Worker: Avoid sending IPC messages for features already counted

When a feature listed on UseCounter::Feature is used on
Shared/ServiceWorkerGlobalScope, it's reported to connecting/controlling
documents via the browser process and counted in their UseCounters.

These IPC messages should be sent only one time per feature, but unfortunately
"worker->browser" IPC is sent every time a feature is used. This is not
efficient.

This CL memorizes feature use in worker-side and avoids sending duplicate IPC
messages to the browser process.

<Example of calling sequence for ServiceWorker>

UseCounter::CountFeature
- WorkerOrWorkletGlobalScope::CountFeature
  (memorizes feature use and returns early if it's already counted)
  - WorkerGlobalScope::ReportFeature
    - ServiceWorkerGlobalScopeProxy::CountFeature
      - ServiceWorkerContextClient (sends an IPC message to the browser)

BUG=714551
==========

[nhiroki, 2017-05-08 09:44:41]

Description was changed from

==========
Worker: Avoid sending IPC messages for features already counted

When a feature listed on UseCounter::Feature is used on
Shared/ServiceWorkerGlobalScope, it's reported to connecting/controlling
documents via the browser process and counted in their UseCounters.

These IPC messages should be sent only one time per feature, but unfortunately
"worker->browser" IPC is sent every time a feature is used. This is not
efficient.

This CL memorizes feature use in worker-side and avoids sending duplicate IPC
messages to the browser process.

<Example of calling sequence for ServiceWorker>

UseCounter::CountFeature
- WorkerOrWorkletGlobalScope::CountFeature
  (memorizes feature use and returns early if it's already counted)
  - WorkerGlobalScope::ReportFeature
    - ServiceWorkerGlobalScopeProxy::CountFeature
      - ServiceWorkerContextClient (sends an IPC message to the browser)

BUG=714551
==========

to

==========
Worker: Avoid sending IPC messages for features already counted

When a feature listed on UseCounter::Feature is used on
Shared/ServiceWorkerGlobalScope, it's reported to connecting/controlling
documents via the browser process and counted in their UseCounters.

These IPC messages should be sent only one time per feature, but unfortunately
"worker->browser" IPC is sent every time a feature is used. This is not
efficient.

This CL memorizes feature use in worker-side and avoids sending duplicate IPC
messages to the browser process.

<Example of calling sequence for ServiceWorker>

UseCounter::CountFeature
- WorkerOrWorkletGlobalScope::CountFeature
  (memorizes feature use and returns early if it's already reported)
  - WorkerGlobalScope::ReportFeature
    - ServiceWorkerGlobalScopeProxy::CountFeature
      - ServiceWorkerContextClient (sends an IPC message to the browser)

BUG=714551
==========

[nhiroki, 2017-05-08 09:44:59]

nhiroki@chromium.org changed reviewers:
+ kinuko@chromium.org

[nhiroki, 2017-05-08 09:45:00]

ptal, thanks!

[nhiroki, 2017-05-08 09:46:10]

Description was changed from

==========
Worker: Avoid sending IPC messages for features already counted

When a feature listed on UseCounter::Feature is used on
Shared/ServiceWorkerGlobalScope, it's reported to connecting/controlling
documents via the browser process and counted in their UseCounters.

These IPC messages should be sent only one time per feature, but unfortunately
"worker->browser" IPC is sent every time a feature is used. This is not
efficient.

This CL memorizes feature use in worker-side and avoids sending duplicate IPC
messages to the browser process.

<Example of calling sequence for ServiceWorker>

UseCounter::CountFeature
- WorkerOrWorkletGlobalScope::CountFeature
  (memorizes feature use and returns early if it's already reported)
  - WorkerGlobalScope::ReportFeature
    - ServiceWorkerGlobalScopeProxy::CountFeature
      - ServiceWorkerContextClient (sends an IPC message to the browser)

BUG=714551
==========

to

==========
Worker: Avoid sending IPC messages for features already counted

When a feature listed on UseCounter::Feature is used on
Shared/ServiceWorkerGlobalScope, it's reported to connecting/controlling
documents via the browser process and counted in their UseCounters.

These IPC messages should be sent only one time per feature, but unfortunately
"worker->browser" IPC is sent every time a feature is used. This is not
efficient.

This CL memorizes feature use in worker-side and avoids sending duplicate IPC
messages to the browser process.

<Example of the calling sequence>

(Some feature is used on ServiceWorkerGlobalScope)
UseCounter::CountFeature
- WorkerOrWorkletGlobalScope::CountFeature
  (memorizes feature use and returns early if it's already reported)
  - WorkerGlobalScope::ReportFeature
    - ServiceWorkerGlobalScopeProxy::CountFeature
      - ServiceWorkerContextClient (sends an IPC message to the browser)

BUG=714551
==========

[commit-bot: I haz the power, 2017-05-08 09:50:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 09:50:59]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[kinuko, 2017-05-08 09:51:45]

lgtm

[nhiroki, 2017-05-08 10:14:24]

The CQ bit was checked by nhiroki@chromium.org

[commit-bot: I haz the power, 2017-05-08 10:14:50]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 12:13:19]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494238464229810,
"parent_rev": "b55d5e08cb57256f0c80eca93c5beaf9d4c821aa", "commit_rev":
"c7acabe9f43065280edf2dee91ae53f6472dcf02"}

[commit-bot: I haz the power, 2017-05-08 12:13:30]

Description was changed from

==========
Worker: Avoid sending IPC messages for features already counted

When a feature listed on UseCounter::Feature is used on
Shared/ServiceWorkerGlobalScope, it's reported to connecting/controlling
documents via the browser process and counted in their UseCounters.

These IPC messages should be sent only one time per feature, but unfortunately
"worker->browser" IPC is sent every time a feature is used. This is not
efficient.

This CL memorizes feature use in worker-side and avoids sending duplicate IPC
messages to the browser process.

<Example of the calling sequence>

(Some feature is used on ServiceWorkerGlobalScope)
UseCounter::CountFeature
- WorkerOrWorkletGlobalScope::CountFeature
  (memorizes feature use and returns early if it's already reported)
  - WorkerGlobalScope::ReportFeature
    - ServiceWorkerGlobalScopeProxy::CountFeature
      - ServiceWorkerContextClient (sends an IPC message to the browser)

BUG=714551
==========

to

==========
Worker: Avoid sending IPC messages for features already counted

When a feature listed on UseCounter::Feature is used on
Shared/ServiceWorkerGlobalScope, it's reported to connecting/controlling
documents via the browser process and counted in their UseCounters.

These IPC messages should be sent only one time per feature, but unfortunately
"worker->browser" IPC is sent every time a feature is used. This is not
efficient.

This CL memorizes feature use in worker-side and avoids sending duplicate IPC
messages to the browser process.

<Example of the calling sequence>

(Some feature is used on ServiceWorkerGlobalScope)
UseCounter::CountFeature
- WorkerOrWorkletGlobalScope::CountFeature
  (memorizes feature use and returns early if it's already reported)
  - WorkerGlobalScope::ReportFeature
    - ServiceWorkerGlobalScopeProxy::CountFeature
      - ServiceWorkerContextClient (sends an IPC message to the browser)

BUG=714551

Review-Url: https://codereview.chromium.org/2857583003
Cr-Commit-Position: refs/heads/master@{#469965}
Committed:
https://chromium.googlesource.com/chromium/src/+/c7acabe9f43065280edf2dee91ae...
==========

[commit-bot: I haz the power, 2017-05-08 12:13:30]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c7acabe9f43065280edf2dee91ae...