Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2857583002: Fix loading success.html at the end of chrome://chrome-signin flow (Closed)

Created:
3 years, 7 months ago by msarda
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Fix loading success.html at the end of chrome://chrome-signin flow This CL lists success.html as an webview accessible resource for the sign-in extension. This CL adds an exception for sign-in extension when for loading webview accessible resources. BUG=709117 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2831183003 Cr-Commit-Position: refs/heads/master@{#467739} (cherry picked from commit 8fdab62089307f5fe2307335dd1c71c4c6661867) Review-Url: https://codereview.chromium.org/2857583002 . Cr-Commit-Position: refs/branch-heads/3071@{#347} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/89b5bfc4897cbc1efcbff39bd568386cc24f4da6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -0 lines) Patch
M chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc View 1 chunk +27 lines, -0 lines 0 comments Download
M extensions/browser/url_request_util.cc View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
msarda
3 years, 7 months ago (2017-05-02 13:40:04 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
89b5bfc4897cbc1efcbff39bd568386cc24f4da6.

Powered by Google App Engine
This is Rietveld 408576698