base/trace_event/trace_event_argument.cc - Issue 2857543002: tracing: Simplify TraceEventMemoryOverhead, use an enum insted of a map

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/trace_event_argument.cc

Issue 2857543002: tracing: Simplify TraceEventMemoryOverhead, use an enum insted of a map (Closed)

Patch Set: Fix compiler issues + omit empty values Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/trace_event/trace_event_argument.cc

diff --git a/base/trace_event/trace_event_argument.cc b/base/trace_event/trace_event_argument.cc

index 646b1f2168794fca6ec2108b085b1014a2205830..fa1c91ba6ca4bdc1867e9f18b25545a092cd4c60 100644

--- a/base/trace_event/trace_event_argument.cc

+++ b/base/trace_event/trace_event_argument.cc

@@ -465,7 +465,7 @@ void TracedValue::AppendAsTraceFormat(std::string* out) const {

void TracedValue::EstimateTraceMemoryOverhead(

TraceEventMemoryOverhead* overhead) {

- overhead->Add("TracedValue",

+ overhead->Add(TraceEventMemoryOverhead::kTracedValue,

/* allocated size */

pickle_.GetTotalAllocatedSize(),

/* resident size */

« no previous file with comments | « base/trace_event/trace_buffer.cc ('k') | base/trace_event/trace_event_impl.cc » ('j') | no next file with comments »