base/trace_event/trace_event_impl.cc - Issue 2857543002: tracing: Simplify TraceEventMemoryOverhead, use an enum insted of a map

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/trace_event_impl.cc

Issue 2857543002: tracing: Simplify TraceEventMemoryOverhead, use an enum insted of a map (Closed)

Patch Set: Fix compiler issues + omit empty values Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/trace_event/trace_event_impl.cc

diff --git a/base/trace_event/trace_event_impl.cc b/base/trace_event/trace_event_impl.cc

index cb23eb474c54e605f9f83f01367b896d1d445a5f..16ce0fa79ea8f8d6800de9da91506bc424a0f644 100644

--- a/base/trace_event/trace_event_impl.cc

+++ b/base/trace_event/trace_event_impl.cc

@@ -198,7 +198,7 @@ void TraceEvent::UpdateDuration(const TimeTicks& now,

void TraceEvent::EstimateTraceMemoryOverhead(

TraceEventMemoryOverhead* overhead) {

- overhead->Add("TraceEvent", sizeof(*this));

+ overhead->Add(TraceEventMemoryOverhead::kTraceEvent, sizeof(*this));

if (parameter_copy_storage_)

overhead->AddString(*parameter_copy_storage_);