Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 2857503002: Revert "Verify that constant vectors aren't invalidated during iteration." (Closed)

Created:
3 years, 7 months ago by sof
Modified:
3 years, 7 months ago
Reviewers:
haraken, keishi
CC:
chromium-reviews, kenneth.christiansen, Yoav Weiss, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Verify that constant vectors aren't invalidated during iteration." Back out the problem diagnosis CHECKs() added in r463124; condition not triggered. R=haraken BUG=699269 Review-Url: https://codereview.chromium.org/2857503002 Cr-Commit-Position: refs/heads/master@{#468584} Committed: https://chromium.googlesource.com/chromium/src/+/84f14ff06916d13518306dbdcb87647d10658b7b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M third_party/WebKit/Source/core/css/MediaQueryEvaluator.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/RuleSet.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
sof
please take a look (but only when back from vacation.)
3 years, 7 months ago (2017-05-02 06:46:06 UTC) #5
haraken
LGTM
3 years, 7 months ago (2017-05-02 06:48:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857503002/1
3 years, 7 months ago (2017-05-02 08:32:54 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 08:36:43 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/84f14ff06916d13518306dbdcb87...

Powered by Google App Engine
This is Rietveld 408576698